Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix urlchecker #238

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix urlchecker #238

merged 2 commits into from
Jun 4, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Jun 4, 2024

parallel = FALSE seems to help (for reasons unknown) with errors like 502 Bad Gateway for https://pharmaverse.slack.com.

@walkowif walkowif requested a review from a team as a code owner June 4, 2024 15:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit aa22305.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: aa22305

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@cicdguy cicdguy requested a review from m7pr June 4, 2024 15:42
cicdguy
cicdguy approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CC @m7pr

@walkowif walkowif merged commit 88a6acc into main Jun 4, 2024
26 checks passed
@walkowif walkowif deleted the debug-urlchecker branch June 4, 2024 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cicdguy cicdguy cicdguy approved these changes

@m7pr m7pr Awaiting requested review from m7pr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walkowif @cicdguy