Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New images for CRAN emulations #65

Merged
merged 5 commits into from
Nov 16, 2022
Merged

New images for CRAN emulations #65

merged 5 commits into from
Nov 16, 2022

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Nov 16, 2022

Adds Debian and Fedora images which will be used for CRAN emulations.

@cicdguy cicdguy requested a review from a team as a code owner November 16, 2022 03:48
@cicdguy cicdguy self-assigned this Nov 16, 2022
@cicdguy cicdguy requested a review from gowerc November 16, 2022 03:48
@cicdguy
Copy link
Contributor Author

cicdguy commented Nov 16, 2022

These images will eventually feed into pharmaverse/admiralci#35 or similar workflows.

Copy link
Contributor

@walkowif walkowif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicdguy cicdguy merged commit 3b2f3d8 into main Nov 16, 2022
@cicdguy cicdguy deleted the cran-emulators branch November 16, 2022 13:22
@gowerc
Copy link

gowerc commented Nov 16, 2022

@cicdguy @walkowif ,

If I'm reading this right it looks like you are using the rhub images as your backbone. I just wanted to say that our big issue was that the rhub images don't really track the CRAN machines that well particularly the fedora machines. In particular CRAN is using fedora 36 + clang 15 whilst rhub is using fedora33 + clang 11. This meant we were getting issues on CRAN that we weren't able to reproduce on rHub. I posted an issue about this here:
r-hub/rhub-linux-builders#63

@cicdguy
Copy link
Contributor Author

cicdguy commented Nov 16, 2022

Aw shucks. Ok looks like we need to wait till those images are updated then.

@gowerc
Copy link

gowerc commented Nov 17, 2022

Thus was the basis for my request if we could develop our own internal images that more closely aligned with CRAN's. Even if it was only just for some of the more problematic ones like their fedora and debian machines.

@cicdguy
Copy link
Contributor Author

cicdguy commented Nov 17, 2022

Thus was the basis for my request if we could develop our own internal images that more closely aligned with CRAN's. Even if it was only just for some of the more problematic ones like their fedora and debian machines.

We can look into updating RHub's images for them instead of maintaining our own, that way other users will also benefit from those enhancements.

@gowerc
Copy link

gowerc commented Nov 17, 2022

Makes sense to me :)

cicdguy added a commit that referenced this pull request Nov 17, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 17, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 17, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 17, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 17, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 18, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 18, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 18, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 18, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 20, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
cicdguy added a commit that referenced this pull request Nov 20, 2022
Adds Debian and Fedora images which will be used for CRAN emulations.

Signed-off-by: Dinakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants