Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just comment out the line that breaks; separate task for full fix #245

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Just comment out the line that breaks; separate task for full fix #245

merged 2 commits into from
Mar 18, 2019

Conversation

j-t-t
Copy link
Collaborator

@j-t-t j-t-t commented Mar 17, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #245 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   55.75%   55.73%   -0.02%     
==========================================
  Files          34       34              
  Lines        3460     3459       -1     
==========================================
- Hits         1929     1928       -1     
  Misses       1531     1531

1 similar comment
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #245 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   55.75%   55.73%   -0.02%     
==========================================
  Files          34       34              
  Lines        3460     3459       -1     
==========================================
- Hits         1929     1928       -1     
  Misses       1531     1531

@j-t-t j-t-t requested a review from bpben March 18, 2019 14:45
@j-t-t
Copy link
Collaborator Author

j-t-t commented Mar 18, 2019

The code coverage goes down because I removed a covered line, but I think this is fine, so if this can be merged, then we can finish and tag 2.0

@bpben bpben merged commit 8f0e90f into master Mar 18, 2019
@j-t-t j-t-t deleted the quick_fix branch April 8, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpben bpben Awaiting requested review from bpben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-t-t @bpben