Add optional jax group to enforce compatible jaxlib version. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsarti
requested changes
Nov 13, 2023
README.md
Outdated
| @@ -47,6 +47,8 @@ pip install git+https://github.com/inseq-team/inseq.git | |||
|
|
|||
| Install extras for visualization in Jupyter Notebooks and 🤗 datasets attribution as `pip install inseq[notebook,datasets]`. | |||
|
|
|||
| Install [Jax](https://github.com/google/jax) (optional) with ```poetry install --with jax```. | |||
There was a problem hiding this comment.
Provided that we do not use jax in the library but we only care for it to not crash our jaxtyping, we do not want to ask users to add it here, even if optionally. I think we should remove this.
gsarti
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inseq does not work with older
jaxlibversions.This adds an optional
jaxgroup that specified thejaxandjaxlibdependencies.Related Issue
Closes #234
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make fix-style.[ ] I've written tests for all new methods and classes that I created and successfully ranmake test.[ ] I've written the docstring in Google format for all the methods and classes that I used.