Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LIME and Occlusion outputs #220

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Fix LIME and Occlusion outputs #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fcdee0
Fix LIME return
gsarti Oct 5, 2023
36b1e23
Fix Occlusion and LIME default aggregation
gsarti Oct 5, 2023
dfd046d
Update deps
gsarti Oct 5, 2023
3461f0c
Pin torch in requirements
gsarti Oct 5, 2023
f01b6ea
Pin torch in requirements
gsarti Oct 5, 2023
31a588a
Update lock
gsarti Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions inseq/attr/feat/perturbation_attribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from captum.attr import Occlusion

from ...data import (
CoarseFeatureAttributionSequenceOutput,
CoarseFeatureAttributionStepOutput,
GranularFeatureAttributionStepOutput,
)
from ...utils import Registry
Expand Down Expand Up @@ -46,7 +46,7 @@ def attribute_step(
self,
attribute_fn_main_args: Dict[str, Any],
attribution_args: Dict[str, Any] = {},
) -> CoarseFeatureAttributionSequenceOutput:
) -> CoarseFeatureAttributionStepOutput:
r"""Sliding window shapes is defined as a tuple.
First entry is between 1 and length of input.
Second entry is given by the embedding dimension of the underlying model.
Expand Down Expand Up @@ -76,7 +76,7 @@ def attribute_step(
if target_attributions is not None:
target_attributions = target_attributions[:, :, 0].abs()

return CoarseFeatureAttributionSequenceOutput(
return CoarseFeatureAttributionStepOutput(
source_attributions=source_attributions,
target_attributions=target_attributions,
)
Expand Down Expand Up @@ -111,4 +111,9 @@ def attribute_step(
raise NotImplementedError(
"LIME attribution with attribute_target=True currently not supported for encoder-decoder models."
)
super().attribute_step(attribute_fn_main_args, attribution_args)
out = super().attribute_step(attribute_fn_main_args, attribution_args)
return GranularFeatureAttributionStepOutput(
source_attributions=out.source_attributions,
target_attributions=out.target_attributions,
sequence_scores=out.sequence_scores,
)
3 changes: 2 additions & 1 deletion inseq/data/attribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def from_step_attributions(
"""
attr = attributions[0]
num_sequences = len(attr.prefix)
if not all([len(attr.prefix) == num_sequences for attr in attributions]):
if not all(len(attr.prefix) == num_sequences for attr in attributions):
raise ValueError("All the attributions must include the same number of sequences.")
seq_attributions = []
sources = None
Expand Down Expand Up @@ -716,6 +716,7 @@ class CoarseFeatureAttributionSequenceOutput(FeatureAttributionSequenceOutput):

def __post_init__(self):
super().__post_init__()
self._aggregator = []


@dataclass(eq=False, repr=False)
Expand Down
Loading