chore: move dev deps into project.optional-dependencies
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
update-deps
branch
from
c46e0aa
to
5a6b67a
Compare
chenrui333
changed the title
project.optional-dependencies.devproject.optional-dependencies
Signed-off-by: Rui Chen <[email protected]>
|
Yeah, I was thinking of doing this. However, I think you might need to tell tox that it needs to install that extra now for tests to work, and should probably note something about it in CONTRIBUTING.md or one of those dev docs. |
dbarnett
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
However, I think you might need to tell tox that it needs to install that extra now for tests to work, and should probably note something about it in CONTRIBUTING.md or one of those dev docs.
Here ya go, pushed a commit fixing those things to your review branch. Should pass tests and be good to merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing 4.4.0 release build, seeing bunch of dev deps pulled in, thus updating the pyproject.toml.