Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for unsupported local target path #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmitchell
Copy link
Contributor

Addresses concern raised in #43.

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@domenkozar
Copy link
Contributor

I'm not sure this is the best UX. If we agree that git cloning local paths doesn't make sense, maybe git vs local path could be determined if path is an URI or not. That would get rid of fallback logic and confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants