Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use src = ./. #119

Open
nh2 opened this issue Aug 24, 2018 · 3 comments
Open

Don't use src = ./. #119

nh2 opened this issue Aug 24, 2018 · 3 comments

Comments

@nh2
Copy link
Member

nh2 commented Aug 24, 2018

stack2nix currently uses src = ./. for the current project, which means it adds huge dirs like .stack-work or potentially .git to the build environment, resulting in

warning: dumping very large path (> 256 MiB); this may run out of memory

and slow builds.

It should filterSource those away (at least .stack-work), and probably also handle the basename problem by using builtins.path.
nh2 added a commit to nh2/stack2nix that referenced this issue Aug 24, 2018
@nh2
Don't use src = ./. for stack2nix itself. See input-output-hk#119.
3e1a631 
This is NOT the fix for input-output-hk#119; that one is about making stack2nix
generate fixes like this one, for all packages you run it on.
This was referenced Aug 24, 2018
Closed
Merged
nh2 added a commit to nh2/stack2nix that referenced this issue Aug 25, 2018
@nh2
Don't use src = ./. for stack2nix itself. See input-output-hk#119.
f9484fa 
This is NOT the fix for input-output-hk#119; that one is about making stack2nix
generate fixes like this one, for all packages you run it on.
nh2 added a commit to nh2/stack2nix that referenced this issue Aug 25, 2018
@nh2
Don't use src = ./. for stack2nix itself. See input-output-hk#119.
9d390be 
This is NOT the fix for input-output-hk#119; that one is about making stack2nix
generate fixes like this one, for all packages you run it on.
domenkozar added a commit that referenced this issue Aug 25, 2018
@domenkozar
Merge pull request #121 from nh2/dont-use-full-src-for-stack2nix-itself
030d161 
Don't use `src = ./.` for stack2nix itself. See #119.
nh2 referenced this issue in nmattia/snack Aug 30, 2018
@nmattia
Reimplement snack-exe in haskell
2c9677c
@domenkozar
Copy link
Contributor

This was merged in master, so closing.

@nh2
Copy link
Member Author

nh2 commented Sep 4, 2018

@domenkozar What fixed this?

As mentioned in nh2@9d390be

This is NOT the fix for #119; that one is about making stack2nix
generate fixes like this one, for all packages you run it on.

@nh2 nh2 reopened this Sep 4, 2018
@domenkozar
Copy link
Contributor

Sorry, was confused by the commit message.

@domenkozar domenkozar mentioned this issue Nov 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenkozar @nh2