Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

[CAD-2169] Expose API types in a separate package #112

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Oct 30, 2020

https://jira.iohk.io/browse/CAD-2169

Original PR by @hasufell.
Rebased, fixed Cabal build, fixed tests and some minor things.

Note that running tests with Stack now requires:

stack test --fast -j`nproc` --flag 'smash:testing-mode' --flag 'smash-servant-types:testing-mode'

@ksaric
Copy link
Contributor Author

ksaric commented Oct 30, 2020

Addressing #110.

@ksaric ksaric mentioned this pull request Oct 30, 2020
2 tasks
@ksaric ksaric requested a review from hasufell October 30, 2020 13:21
@ksaric
Copy link
Contributor Author

ksaric commented Oct 30, 2020

This is going to be squash-merged if possible since we don't want 5 commits for a single PR.

@hasufell
Copy link

This is going to be squash-merged if possible since we don't want 5 commits for a single PR.

That's fine. What you can do in such a case is add this to the end of the commit message (the github API does that too):

Co-authored-by: Julian Ospald <[email protected]>

Copy link

@hasufell hasufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ksaric ksaric requested a review from jbgi November 2, 2020 13:02
@ksaric
Copy link
Contributor Author

ksaric commented Nov 2, 2020

I have no idea why this is failing, my attempts at fixing the Nix thingies fail.

@jbgi jbgi force-pushed the ksaric/CAD-2169 branch 5 times, most recently from c8a71e9 to 88cd6ec Compare November 2, 2020 17:47
@jbgi
Copy link
Contributor

jbgi commented Nov 2, 2020

The nix issue was that in haskell.nix, the flags were set only for the smash package but not for the new package.
I added a new smash-exe-testing nix target to keep the normal binary (without testing flag) as default for production.

@jbgi
Copy link
Contributor

jbgi commented Nov 2, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 908fab6 into master Nov 2, 2020
@iohk-bors iohk-bors bot deleted the ksaric/CAD-2169 branch November 2, 2020 18:47
@ksaric ksaric mentioned this pull request Dec 10, 2020
@ksaric ksaric mentioned this pull request Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants