Release/0.9.4 #142
Merged
Release/0.9.4 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…height calculation
…css-modules-notation Add support for *.module.scss file name convention
While debugging a testing issue with the new scrollbar component i stumbled over the known problem of „react-test-renderer“ not being able to handle element refs correctly (since it doesn’t involve any real DOM rendering). You can read more about that issue here: facebook/react#7740 This was the root cause and i couldnt make it work with react-test-renderer, so i refactored all the snapshot tests to use enzyme (which supports full DOM rendering). You can see the difference (react-test-renderer outputs a JSON with react component „markup“ whereas enzyme outputs only plain DOM nodes)
* [DDW-170] Improve password repeat feature * [DDW-170] Update changelog * [DDW-170] Prepare changelog for vNext * 0.9.4-rc.1 * [DDW-170] Add className prop to password input * 0.9.4-rc.2 * [DDW-170] Fix tooltip regression on hover * 0.9.4-rc.3 * [DDW-170] Fixes show on focus feature * 0.9.4-rc.4 * [DDW-170] Make tooltip border-radius configurable * 0.9.4-rc.5 * [DDW-170] Remove margin from password input * [DDW-170] Fix custom error logic * 0.9.4-rc.6 * [DDW-170] Fix pw input bg colors * 0.9.4-rc.7
…-repeat' into develop # Conflicts: # package.json # source/components/PasswordInput.js # stories/PasswordInput.stories.js
# Conflicts: # CHANGELOG.md # __tests__/__snapshots__/Tooltip.test.js.snap # package.json # source/components/Bubble.js # source/components/HOC/GlobalListeners.js # source/components/PasswordInput.js # source/components/ScrollBar.js # source/components/Select.js # source/components/Tooltip.js # source/skins/simple/PasswordInputSkin.js # source/skins/simple/TooltipSkin.js # source/themes/API/tooltip.js # source/themes/simple/SimplePasswordInput.scss # source/themes/simple/SimpleTooltip.scss # stories/PasswordInput.stories.js # stories/PasswordInput.stories.scss # stories/Tooltip.stories.js # yarn.lock
nikolaglumac
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the 0.9.4 release into master