Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt12/diffusion test dns recoverability #3707

Merged
merged 5 commits into from
May 19, 2022

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Apr 12, 2022

No description provided.

@bolt12 bolt12 linked an issue Apr 12, 2022 that may be closed by this pull request
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch 2 times, most recently from ddf4317 to 8464250 Compare April 18, 2022 16:51
@bolt12 bolt12 marked this pull request as ready for review April 18, 2022 16:53
@bolt12 bolt12 requested a review from coot as a code owner April 18, 2022 16:53
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch 2 times, most recently from 4474ba0 to 3769459 Compare April 20, 2022 09:37
@bolt12 bolt12 changed the base branch from master to bolt12/diffusion-test-timeouts April 20, 2022 09:46
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from a81e8b8 to ca13bcc Compare April 21, 2022 09:04
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from 3769459 to ac51d85 Compare April 21, 2022 09:06
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from ca13bcc to 21b194f Compare April 21, 2022 09:26
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from ac51d85 to b274b2c Compare April 21, 2022 09:26
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from 21b194f to a9a4a18 Compare April 22, 2022 14:44
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from b274b2c to 331acb0 Compare April 22, 2022 14:53
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from a9a4a18 to 14f9436 Compare April 26, 2022 21:55
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from 331acb0 to 974d516 Compare April 26, 2022 21:58
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch 2 times, most recently from be38e68 to 2765b88 Compare May 6, 2022 10:52
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from 974d516 to 29dde73 Compare May 6, 2022 10:53
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from 2765b88 to 29b15b8 Compare May 6, 2022 13:28
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from 29dde73 to ee90827 Compare May 6, 2022 13:29
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-timeouts branch from 29b15b8 to a81cab0 Compare May 6, 2022 15:50
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from ee90827 to ef53cfe Compare May 6, 2022 15:50
@bolt12 bolt12 changed the base branch from bolt12/diffusion-test-timeouts to master May 9, 2022 09:52
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from ef53cfe to eae62b2 Compare May 9, 2022 11:19
@bolt12
Copy link
Contributor Author

bolt12 commented May 10, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 10, 2022

👎 Rejected by too few approved reviews

Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only important question is if we should make the verify function check the time, see the comment in the Added DNS Recoverability test patch.

@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from eae62b2 to 8660680 Compare May 17, 2022 10:21
@bolt12 bolt12 requested a review from coot May 17, 2022 10:22
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from 8660680 to f8fd974 Compare May 17, 2022 15:40
Refactor RootPeersDNS tests to use this change instead of a script of domain maps.

Updates JoinNetwork command with possible IP change. If a node restarts with a new IP there's a new thread to update the Domain maps accordingly after some delay.

Removed self from DNSMap in DiffusionScript gen

Added tracing for DNSMap updating
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-dns-recoverability branch from f8fd974 to c09ee1a Compare May 18, 2022 11:16
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolt12
Copy link
Contributor Author

bolt12 commented May 19, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

@iohk-bors iohk-bors bot merged commit 505674d into master May 19, 2022
@iohk-bors iohk-bors bot deleted the bolt12/diffusion-test-dns-recoverability branch May 19, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants