-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt12/diffusion test dns recoverability #3707
Conversation
ddf4317
to
8464250
Compare
4474ba0
to
3769459
Compare
a81e8b8
to
ca13bcc
Compare
3769459
to
ac51d85
Compare
ca13bcc
to
21b194f
Compare
ac51d85
to
b274b2c
Compare
21b194f
to
a9a4a18
Compare
b274b2c
to
331acb0
Compare
a9a4a18
to
14f9436
Compare
331acb0
to
974d516
Compare
be38e68
to
2765b88
Compare
974d516
to
29dde73
Compare
2765b88
to
29b15b8
Compare
29dde73
to
ee90827
Compare
29b15b8
to
a81cab0
Compare
ee90827
to
ef53cfe
Compare
ef53cfe
to
eae62b2
Compare
bors merge |
👎 Rejected by too few approved reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The only important question is if we should make the verify
function check the time, see the comment in the Added DNS Recoverability test
patch.
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Show resolved
Hide resolved
eae62b2
to
8660680
Compare
8660680
to
f8fd974
Compare
Refactor RootPeersDNS tests to use this change instead of a script of domain maps. Updates JoinNetwork command with possible IP change. If a node restarts with a new IP there's a new thread to update the Domain maps accordingly after some delay. Removed self from DNSMap in DiffusionScript gen Added tracing for DNSMap updating
f8fd974
to
c09ee1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors merge |
No description provided.