Memory leak in networking code #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
changed the title
coot
force-pushed
the
coot/network-memory-leak
branch
from
d336690 to
b9a62de
Compare
5 tasks
coot
force-pushed
the
coot/network-memory-leak
branch
from
b9a62de to
b3ccb1f
Compare
|
Requires: IntersectMBO/cardano-base#89 |
coot
force-pushed
the
coot/network-memory-leak
branch
from
1c3159a to
d59b2a7
Compare
dcoutts
approved these changes
Apr 8, 2020
| @@ -72,17 +73,17 @@ socketAsMuxBearer sduTimeout_m tracer sd = | |||
| Nothing -> do | |||
| traceWith tracer $ Mx.MuxTraceSDUReadTimeoutException | |||
| throwM $ Mx.MuxError Mx.MuxSDUReadTimeout "Mux SDU Timeout" callStack | |||
| Just r -> return r | |||
| Just !r -> return r | |||
There was a problem hiding this comment.
This one is a bit odd. It's a bang pattern on a pair right? It's the result of recvRem so we should add strictness there instead.
Do it on the two components of the result pair (header {Mx.msBlob = blob}, ts).
!ts <- getMonotonicTime
and
let !header' = header {Mx.msBlob = blob}
return (header', ts)
There was a problem hiding this comment.
Pushed a patch to implement this suggestion.
Also remove unneccessary 'MuxSDUHeader' type from Mux.Codec module.
Simplify the NFData Expiry instance, since NF=WHNF for this type. Eliminate the now-unused NFData SlotNo instance.
dcoutts
force-pushed
the
coot/network-memory-leak
branch
from
d59b2a7 to
bf45bd7
Compare
Bang things nearer their construction site, and don't bang pairs.
I've dropped the changes that needed this and did it in a way that didn't need them. |
|
bors merge |
coot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.