coot/network memory leak #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TVar should be StrictTVar, this is left as a todo.
coot
added
bug
coot
requested review from
dcoutts and
Jimbo4350
and removed request for
dcoutts
|
We need first merge IntersectMBO/ouroboros-network#1902 |
This was referenced Apr 7, 2020
dcoutts
reviewed
Apr 8, 2020
Comment on lines
+223
to
+224
| -- TODO: use StrictTVar | ||
| atomically $ writeTVar varTip $! tip |
There was a problem hiding this comment.
This patch is no longer necessary. The node top level no longer reads the tip at all for use in tracers.
There was a problem hiding this comment.
I used it today to trace epoch boundary into eventlog, but this could be done in consensus as well (it was just simpler to do that here, in bare IO :) with out any abstract constraints)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR updates for changes in
coot/network-memory-leakbranch inouroboros-network, and fixes a memory leak incardano-node.This PR results/does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.