Reinit the dns lib before each call #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested changes
Apr 6, 2020
ouroboros-network-framework/src/Ouroboros/Network/Subscription/Dns.hs
Outdated
Show resolved
Hide resolved
The dns library only reads /etc/resolv.conf once which means that inorder to cope with changing networks conditions we need to reinit the library before each use.
|
bors r+ |
coot
added a commit
that referenced
this pull request
May 16, 2022
1891: Reinit the dns lib before each call r=karknu a=karknu The dns library only reads /etc/resolv.conf once which means that inorder to cope with changing networks conditions we need to reinit the library before each use. Workaround for the bug reported in IntersectMBO/cardano-node#731 Co-authored-by: Karl Knutsson <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dns library only reads /etc/resolv.conf once which means that inorder to
cope with changing networks conditions we need to reinit the library
before each use.
Workaround for the bug reported in IntersectMBO/cardano-node#731