Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS servers changes requires a restart to take affect #731

Closed
karknu opened this issue Mar 27, 2020 · 1 comment
Closed

DNS servers changes requires a restart to take affect #731

karknu opened this issue Mar 27, 2020 · 1 comment
Assignees
@karknu
Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node. DNS Issues / PRs related to DNS networking Issues and PRs related to networking priority high issues/PRs that MUST be addressed. The release can't happen without this;
Milestone
S10 2020-04-09

Comments

@karknu
Copy link
Contributor

karknu commented Mar 27, 2020

During changing network conditions (for example moving from Wifi to LTE) the new network's DNS server is not used. If the configuration uses DNS names the node will be unable to reconnect to its peers.

The root cause of this is either a bug in ouroboros-network or the dns package.
@karknu karknu added the bug Something isn't working label Mar 27, 2020
@karknu
Copy link
Contributor Author

karknu commented Mar 31, 2020

The dns package doesn't check for changes in /etc/resolv.conf. It reads it once when it is initialized. This means that to make sure that we can handle chancing network conditions we need to reinitialize it before every use :| .

@karknu karknu self-assigned this Mar 31, 2020
@coot coot added byron Required for a Byron mainnet: replace the old core nodes with cardano-node. networking Issues and PRs related to networking priority high issues/PRs that MUST be addressed. The release can't happen without this; labels Apr 2, 2020
@coot coot added this to the S10 2020-04-09 milestone Apr 2, 2020
This was referenced Apr 2, 2020
Merged
Closed
iohk-bors bot added a commit to IntersectMBO/ouroboros-network that referenced this issue Apr 9, 2020
@iohk-bors @karknu @coot
Merge #1891
3d89fa4 
1891: Reinit the dns lib before each call r=karknu a=karknu

The dns library only reads /etc/resolv.conf once which means that inorder to
cope with changing networks conditions we need to reinit the library
before each use.

Workaround for the bug reported in IntersectMBO/cardano-node#731 

Co-authored-by: Karl Knutsson <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
@karknu karknu closed this as completed Apr 14, 2020
@coot coot added the DNS Issues / PRs related to DNS label Jun 24, 2020
@coot coot mentioned this issue Jun 24, 2020
Merged
coot added a commit to IntersectMBO/ouroboros-network that referenced this issue May 16, 2022
@iohk-bors @karknu @coot
Merge #1891
e79504f 
1891: Reinit the dns lib before each call r=karknu a=karknu

The dns library only reads /etc/resolv.conf once which means that inorder to
cope with changing networks conditions we need to reinit the library
before each use.

Workaround for the bug reported in IntersectMBO/cardano-node#731 

Co-authored-by: Karl Knutsson <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
coot added a commit to input-output-hk/typed-protocols that referenced this issue May 16, 2022
@iohk-bors @karknu @coot
Merge #1891
ba5160d 
1891: Reinit the dns lib before each call r=karknu a=karknu

The dns library only reads /etc/resolv.conf once which means that inorder to
cope with changing networks conditions we need to reinit the library
before each use.

Workaround for the bug reported in IntersectMBO/cardano-node#731 

Co-authored-by: Karl Knutsson <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karknu karknu

Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node. DNS Issues / PRs related to DNS networking Issues and PRs related to networking priority high issues/PRs that MUST be addressed. The release can't happen without this;
Projects
None yet
Milestone
S10 2020-04-09
Development

No branches or pull requests
2 participants
@coot @karknu