More intelligent transaction requests #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
added
networking
consensus
intricate
commented
Mar 5, 2020
intricate
force-pushed
the
intricate/1161-new-plan
branch
2 times, most recently
from
569abc0 to
8cd528b
Compare
|
I rebased my wip branch onto commit 8cd528b, and I no longer see the huge number of transactions. Great! |
mrBliss
suggested changes
Mar 5, 2020
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound.hs
Outdated
Show resolved
Hide resolved
| requestedTxIdsInFlight = requestedTxIdsInFlight st - reqNo, | ||
| unacknowledgedTxIds = unacknowledgedTxIds st | ||
| <> Seq.fromList (map fst txids), | ||
| availableTxids = availableTxids st | ||
| <> Map.fromList txids | ||
| } | ||
| mpSnapshot <- atomically mempoolGetSnapshot | ||
| serverIdle n (acknowledgeTxIdsInMempool st' mpSnapshot) |
There was a problem hiding this comment.
I'm sure you and @dcoutts have discussed this already, but just checking again: is this the right and only place to look at the Mempool?
ouroboros-consensus/src/Ouroboros/Consensus/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Winant <[email protected]>
intricate
force-pushed
the
intricate/1161-new-plan
branch
from
8cd528b to
8373478
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1161.
Implements the new plan.