check that Byron can increment its adopted protocol version #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
force-pushed
the
nfrisby/issue-1514-Byron-hardfork-smoke
branch
2 times, most recently
from
0c685cf to
a9a224a
Compare
|
This PR is in Draft status because it currently includes the latest tip of @intricate's PR #1749 -- without that PR's contents, this PR's contents creates disruptively large blocks because of Issue 1161. |
nfrisby
force-pushed
the
nfrisby/issue-1514-Byron-hardfork-smoke
branch
from
a9a224a to
556d89e
Compare
|
The single large commit contains two minor aspects that are tangentially related to the PR's focus.
|
nfrisby
force-pushed
the
nfrisby/issue-1514-Byron-hardfork-smoke
branch
from
556d89e to
251d250
Compare
|
I've requested review. The PR is in Draft just because it's currently rebased onto Luke's "intelligent" transactions PR. I expect an automatic rebase onto master once his is merged. |
nfrisby
force-pushed
the
nfrisby/issue-1514-Byron-hardfork-smoke
branch
from
251d250 to
2657302
Compare
|
Luke's PR is merged! I rebased onto master and marked this PR Ready for Review. |
The Byron to Shelley hard-fork will end the Byron era by adopting a specific protocol version. This commit adds transactions and 'Property's to the RealPBFT tests that confirm the Byron nodes are able to update their protocol version.
nfrisby
force-pushed
the
nfrisby/issue-1514-Byron-hardfork-smoke
branch
from
2657302 to
9ffb6f9
Compare
edsko
approved these changes
Mar 9, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this should be considered to fully address #1514, but it's good first step.
It originally that #1161 is high-priority because of votes: they are replicated and fill up the blocks, making the test quite expensive. Other transactions (so far) haven't been as problematic because duplicate transactions other than votes are invalid.
Therefore this PR is rooted on top of a potential fix for 1161; it's blocked by the corresponding PR. Good news, though: the protocol version update is succeeding when expected.
I'm opening this as Draft since it currently includes the latest state of the other PR.