Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce header validation as concept #1577

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Introduce header validation as concept #1577

merged 1 commit into from
Feb 12, 2020

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Feb 5, 2020

This then paves the way for introducing additional checks
(which this doesn't do yet).

@edsko edsko force-pushed the edsko/validateHeader branch from f7703d0 to ee94e76 Compare February 5, 2020 09:09
This was referenced Feb 5, 2020
Closed
Closed
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

One annoying thing: EBBs (obviously). Block numbers don't always increase. But if we do this generically, then that generic code must be EBB aware 😠

@mrBliss
Copy link
Contributor

mrBliss commented Feb 6, 2020

One annoying thing: EBBs (obviously). Block numbers don't always increase. But if we do this generically, then that generic code must be EBB aware angry

Thinking out loud: what if we make this blk-specific using, e.g., RunNode? The default is increasing, but we can override the implementation for Byron to handle EBBs correctly.

@edsko
Copy link
Contributor Author

edsko commented Feb 6, 2020

No, it doesn't belong in RunNode. We need an abstraction that captures this. It's part of the ledger definition.

@edsko edsko force-pushed the edsko/validateHeader branch 3 times, most recently from 04f4415 to 787b002 Compare February 11, 2020 13:43
@edsko edsko marked this pull request as ready for review February 11, 2020 13:45
@mrBliss mrBliss self-requested a review February 11, 2020 14:46
edsko
edsko commented Feb 11, 2020
View reviewed changes
ouroboros-consensus/src/Ouroboros/Consensus/HeaderValidation.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HeaderValidation.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HeaderValidation.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HeaderValidation.hs Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HeaderValidation.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Ledger/Mock/Block/PBFT.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Util/CBOR.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Util/CBOR.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Storage/ChainDB/Impl/LgrDB.hs Show resolved Hide resolved
ouroboros-consensus/test-util/Test/Util/TestBlock.hs Show resolved Hide resolved
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Feb 11, 2020
mrBliss
mrBliss approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsko edsko force-pushed the edsko/validateHeader branch from 787b002 to 0feda31 Compare February 11, 2020 15:01
@edsko
Copy link
Contributor Author

edsko commented Feb 11, 2020

bors r+

This was referenced Feb 11, 2020
Merged
Merged
iohk-bors bot added a commit that referenced this pull request Feb 11, 2020
@iohk-bors @edsko
Merge #1577
a3a24f7 
1577: Introduce header validation as concept r=edsko a=edsko

This then paves the way for introducing additional checks
(which this doesn't do yet).

Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2020

Build failed

@edsko
Copy link
Contributor Author

edsko commented Feb 12, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 12, 2020
@iohk-bors @edsko
Merge #1577
3411b7a 
1577: Introduce header validation as concept r=edsko a=edsko

This then paves the way for introducing additional checks
(which this doesn't do yet).

Co-authored-by: Edsko de Vries <[email protected]>
@edsko edsko force-pushed the edsko/validateHeader branch from 0feda31 to 7cca829 Compare February 12, 2020 06:42
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 12, 2020

Canceled

@edsko
Copy link
Contributor Author

edsko commented Feb 12, 2020

Rebased and restarted, since Hydra seemed stuck.

@edsko
Copy link
Contributor Author

edsko commented Feb 12, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 12, 2020
@iohk-bors @edsko
Merge #1577
4f91d8e 
1577: Introduce header validation as concept r=edsko a=edsko

This then paves the way for introducing additional checks
(which this doesn't do yet).

Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 12, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 7cca829 into master Feb 12, 2020
@iohk-bors iohk-bors bot deleted the edsko/validateHeader branch February 12, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edsko @mrBliss