Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EBBs only when we expect them #1621

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Feb 11, 2020

No description provided.

@edsko edsko requested a review from mrBliss February 11, 2020 16:11
@edsko
Copy link
Contributor Author

edsko commented Feb 11, 2020

This is only one commit, the first is #1577 .

@edsko
Copy link
Contributor Author

edsko commented Feb 11, 2020

I verified that this can still verify the (mirrored prefix of) the real chain, and that it fails to do so when we change the definition of canBeEBB.

Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edsko edsko force-pushed the edsko/no-unexpected-EBBs branch from 7de0cf4 to 43f97de Compare February 12, 2020 06:55
@edsko
Copy link
Contributor Author

edsko commented Feb 12, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 12, 2020
1621: Allow EBBs only when we expect them r=edsko a=edsko



Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 12, 2020

@iohk-bors iohk-bors bot merged commit 43f97de into master Feb 12, 2020
@iohk-bors iohk-bors bot deleted the edsko/no-unexpected-EBBs branch February 12, 2020 07:07
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants