windows vectored io for sockets #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/windows-vectored-io
branch
from
2ecc959 to
ef081a4
Compare
coot
force-pushed
the
coot/windows-api
branch
3 times, most recently
from
bfc1efe to
565bb29
Compare
coot
force-pushed
the
coot/windows-vectored-io
branch
from
ef081a4 to
6d5204e
Compare
coot
force-pushed
the
coot/windows-api
branch
from
565bb29 to
2f81dec
Compare
coot
force-pushed
the
coot/windows-vectored-io
branch
2 times, most recently
from
dbeaa16 to
affb6ea
Compare
coot
force-pushed
the
coot/windows-vectored-io
branch
from
affb6ea to
3806a47
Compare
coot
force-pushed
the
coot/windows-vectored-io
branch
from
3806a47 to
9c20430
Compare
karknu
reviewed
Feb 28, 2020
coot
force-pushed
the
coot/windows-vectored-io
branch
from
9c20430 to
085c24a
Compare
|
bors r+ |
Merge conflict |
Run pipe tests on windows using `pipeChannelFromNamedPipe` This patch makes test-network buildable again and enables pipes tests on Windows.
HsSendBuf is taking now a pointer to `WSABUF` and passes it directly to WSASend. This will allow us to implement vectored io (send part) for lazy bytestrings.
As in the network package, we use the strict ByteString version to receive a single ByteSting and put it as a sole chunk in a lazy ByteString. `defaultChunkSize` is 32kb which which is roughly 21 tcp segments.
Let the user of the library choose wether to use 'System.Win32.Async.Socket.ByteString' or 'System.Win32.Async.Socket.ByteString.Lazy'.
Limit the scope of masked exceptions only to the 'Network.Socket.connect' / 'Network.Socket.accept' call.
coot
force-pushed
the
coot/windows-vectored-io
branch
from
085c24a to
7c582b7
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this PR is opened to merge into
coot/windows-api, but after #1516 is merged it will be re-targeted tomaster- it's just to make the diff adequate.This PR provides vectored IO for sockets, vectored IO for file handles will be done at a later stage.
It also includes documentation overview, which will be useful for other teams (
cardano-walletorcardano-launcher).