Windows compatiblity #1516
Merged
Windows compatiblity #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/windows-api
branch
from
5948716 to
91bf5f0
Compare
coot
force-pushed
the
coot/windows-api
branch
from
91bf5f0 to
d14f5a5
Compare
karknu
approved these changes
Feb 3, 2020
| { nsSubscriptionTracer | ||
| , nsMuxTracer | ||
| , nsHandshakeTracer | ||
| , nsErrorPolicyTracer |
There was a problem hiding this comment.
In cardano-sl's style the prefix would be nst not ns. But I'm not sure we have any rules for this in ourboros-network.
There was a problem hiding this comment.
I know, but we already have nst prefix in NetworkServerTracers :/
Yes, once snockets are merged they can be used in |
coot
force-pushed
the
coot/snockets
branch
3 times, most recently
from
c0c6e09 to
11ef1c7
Compare
coot
force-pushed
the
coot/windows-api
branch
2 times, most recently
from
bfc1efe to
565bb29
Compare
Fixed :) |
Run pipe tests on windows using `pipeChannelFromNamedPipe` This patch makes test-network buildable again and enables pipes tests on Windows.
This allows to connect to the diffusion layer using unix socket or named pipe. Currently we don't support local clients connected using a tcp socket, but this could be easily added in the future.
This only allows to connect to a node using a unix socket or a named pipe.
A subscription worker which works over ClientSnocket. It is integrated into data diffusion `Ouroboros.Network.Diffusion`. * `ouroboros-network` - compiler and runs all its tests on Windows. * `ouroboros-consensus` - windows support is tracked in #1082
This is useful for running all tests on windows. Currently it does not include `ouroboros-consensus` tests, since `ouroboros-consensus` does not compile on windows.
coot
force-pushed
the
coot/windows-api
branch
from
565bb29 to
2f81dec
Compare
|
I merged this into #1499 - so I have less PRs to re-base. |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 28, 2020
1552: windows vectored io for sockets r=coot a=coot Currently this PR is opened to merge into `coot/windows-api`, but after #1516 is merged it will be re-targeted to `master` - it's just to make the diff adequate. This PR provides vectored IO for sockets, vectored IO for file handles will be done at a later stage. It also includes documentation overview, which will be useful for other teams (`cardano-wallet` or `cardano-launcher`). Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three things:
ErrorPoliciesby removing callback which classifies return values of error policiesclientSubscriptionWorkerwhich subscribes to a unix socket or named pipe on windows. It is a simplified version ofipSubscriptionWorker../scripts/test.sh- a script to run tests on widnows - all are green 🎉 😎It depends on #1499 - which needs to be merge first, it addresses #1501.