Snockets #1499
Merged
Snockets #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/snockets
branch
4 times, most recently
from
cdacfc4 to
a32a4ed
Compare
Merged
coot
force-pushed
the
coot/snockets
branch
2 times, most recently
from
c5ad270 to
fea4c5a
Compare
karknu
requested changes
Jan 30, 2020
coot
force-pushed
the
coot/snockets
branch
2 times, most recently
from
d64879d to
69d6206
Compare
coot
force-pushed
the
coot/snockets
branch
3 times, most recently
from
a2ea19c to
c0c6e09
Compare
karknu
reviewed
Feb 3, 2020
| , LocalSnocket | ||
| , localSnocket | ||
| , LocalAddress | ||
| , clientAddressFromPath |
There was a problem hiding this comment.
Shouldn't this be localAddressFromPath?
Error handler was attached to `putTMVar` instead of the `Network.Socketconnect` call.
namedPipeAsBearer - create a mux bearer from a named pipe
'PipeChannel' is introduced to abstract read / write pipe operations.
Run pipe tests on windows using `pipeChannelFromNamedPipe` This patch makes test-network buildable again and enables pipes tests on Windows.
Run pipe tests on windows using `pipeChannelFromNamedPipe` This patch makes test-network buildable again and enables pipes tests on Windows.
This allows to connect to the diffusion layer using unix socket or named pipe. Currently we don't support local clients connected using a tcp socket, but this could be easily added in the future.
This only allows to connect to a node using a unix socket or a named pipe.
A subscription worker which works over ClientSnocket. It is integrated into data diffusion `Ouroboros.Network.Diffusion`. * `ouroboros-network` - compiler and runs all its tests on Windows. * `ouroboros-consensus` - windows support is tracked in #1082
This is useful for running all tests on windows. Currently it does not include `ouroboros-consensus` tests, since `ouroboros-consensus` does not compile on windows.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 14, 2020
1499: Snockets r=coot a=coot This PR introduce snockets which abstract the interface for Berkeley sockets and named pipes (windows). The PR consist of smaller reviewable and mostly buildable patches. Highlight of changes: Win32-network -------------------- A bug fixed in `System.Win32.Async.connect` network-mux ----------------- * `runMuxWithPipes` handles named pipes as well * new tests which include posix pipes, named pipes and queues * mux-demo - windows named pipe demo using mux: an echo server and client ouroboros-network ------------------------- * `IOManager` - system indepdendent IO manager. On Windows using `System.Win32.Async.withIOManager`, on posix it's a no-op * `Snockets` - abstraction which handles both Berkeley sockets and Windows named pipes, together with smart constructors for both. * `Snocket` shim layer with type alliases for different paltforms (posix / win32) * demo-chain-sync - can now run on Windows with named pipes future work --------------- * `NodeToClient` and `NodeToNode` which are using named pipes for local clients on windows. Co-authored-by: Marcin Szamotulski <[email protected]>
|
bors +cancel |
|
bors r- |
Canceled |
|
bors r+ |
|
bors try |
|
bors ping |
|
pong |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 18, 2020
1499: Snockets r=coot a=coot This PR introduce snockets which abstract the interface for Berkeley sockets and named pipes (windows). The PR consist of smaller reviewable and mostly buildable patches. Highlight of changes: Win32-network -------------------- A bug fixed in `System.Win32.Async.connect` network-mux ----------------- * `runMuxWithPipes` handles named pipes as well * new tests which include posix pipes, named pipes and queues * mux-demo - windows named pipe demo using mux: an echo server and client ouroboros-network ------------------------- * `IOManager` - system indepdendent IO manager. On Windows using `System.Win32.Async.withIOManager`, on posix it's a no-op * `Snockets` - abstraction which handles both Berkeley sockets and Windows named pipes, together with smart constructors for both. * `Snocket` shim layer with type alliases for different paltforms (posix / win32) * demo-chain-sync - can now run on Windows with named pipes future work --------------- * `NodeToClient` and `NodeToNode` which are using named pipes for local clients on windows. Co-authored-by: Marcin Szamotulski <[email protected]>
Build failed |
tryBuild succeeded |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 18, 2020
1499: Snockets r=karknu a=coot This PR introduce snockets which abstract the interface for Berkeley sockets and named pipes (windows). The PR consist of smaller reviewable and mostly buildable patches. Highlight of changes: Win32-network -------------------- A bug fixed in `System.Win32.Async.connect` network-mux ----------------- * `runMuxWithPipes` handles named pipes as well * new tests which include posix pipes, named pipes and queues * mux-demo - windows named pipe demo using mux: an echo server and client ouroboros-network ------------------------- * `IOManager` - system indepdendent IO manager. On Windows using `System.Win32.Async.withIOManager`, on posix it's a no-op * `Snockets` - abstraction which handles both Berkeley sockets and Windows named pipes, together with smart constructors for both. * `Snocket` shim layer with type alliases for different paltforms (posix / win32) * demo-chain-sync - can now run on Windows with named pipes future work --------------- * `NodeToClient` and `NodeToNode` which are using named pipes for local clients on windows. Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce snockets which abstract the interface for Berkeley sockets and named pipes (windows).
The PR consist of smaller reviewable and mostly buildable patches.
Highlight of changes:
Win32-network
A bug fixed in
System.Win32.Async.connectnetwork-mux
runMuxWithPipeshandles named pipes as wellouroboros-network
IOManager- system indepdendent IO manager. On Windows usingSystem.Win32.Async.withIOManager, on posix it's a no-opSnockets- abstraction which handles both Berkeley sockets and Windows named pipes, together with smart constructors for both.Snocketshim layer with type alliases for different paltforms (posix / win32)future work
NodeToClientandNodeToNodewhich are using named pipes for local clients on windows.