Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain observer interface #281

Merged
merged 11 commits into from
Jun 22, 2022
Merged

Add chain observer interface #281

merged 11 commits into from
Jun 22, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 20, 2022

This PR implements a Chain Observer interface:

  • Add a ChainObserver trait
  • Add a FakeObserver that implements a ChainObserver
  • Use a FakeObserver in Mithril Aggregator
  • Use a FakeObserver in Mitril Signer

Closes #250

@github-actions
Copy link

github-actions bot commented Jun 20, 2022

Unit Test Results

208 tests  +3   208 ✔️ +3   6m 53s ⏱️ -53s
  17 suites ±0       0 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit bdbdabf. ± Comparison against base commit f2d5f8a.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/250-chain-observer branch from 307c49d to d32379b Compare June 20, 2022 10:30
@jpraynaud jpraynaud force-pushed the jpraynaud/250-chain-observer branch 2 times, most recently from 9981f96 to f44dfc6 Compare June 21, 2022 13:28
@jpraynaud jpraynaud marked this pull request as ready for review June 21, 2022 13:32
@jpraynaud jpraynaud mentioned this pull request Jun 21, 2022
7 tasks
@jpraynaud jpraynaud force-pushed the jpraynaud/250-chain-observer branch from f44dfc6 to bdbdabf Compare June 22, 2022 09:25
@jpraynaud jpraynaud merged commit a768c45 into main Jun 22, 2022
@jpraynaud jpraynaud deleted the jpraynaud/250-chain-observer branch June 22, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide interface for retrieving SD from external source in Aggregator/Signer
2 participants