-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-8889 - Fix ci failures #121
Conversation
WalkthroughThe changes involve updates to GitHub Actions workflow configurations, with a job being renamed and the setup of Nix being modified to include specific environment variables and configurations. Additionally, Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (9)
- flake.lock
- package-lock.json
- package.json
- packages/adapter/package.json
- packages/language/core/v1/package.json
- packages/runtime/client/rest/package.json
- packages/runtime/core/package.json
- packages/runtime/lifecycle/package.json
- packages/wallet/package.json
Files selected for processing (2)
- .github/workflows/test-suite.yaml (1 hunks)
- .gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
- .gitignore
Additional comments: 2
.github/workflows/test-suite.yaml (2)
1-30: The changes to the GitHub Actions workflow file, including the addition of environment variables and the setup of Nix with specific configurations, appear to be correctly implemented and align with the PR's objective to fix CI failures. The use of
nix develop
for building and testing the project is appropriate, assuming that the project is set up to use Nix Flakes.30-30: Verify if the use of
npm i && npm run build
within thenix develop
command is intentional, considering the shift from npm to Yarn as indicated by the changes in the.gitignore
file. If the project has moved to Yarn, these commands should be updated accordingly.
Verification result:
The review comment regarding the use of
npm
commands in the.github/workflows/test-suite.yaml
file is valid. The search results show thatnpm
commands are still present in various documentation files, which may need to be updated if the project has fully transitioned to Yarn. However, the presence ofnpm
commands in documentation does not necessarily indicate that they are still used in the actual build and development scripts. It is important to verify whether the CI workflow and development environment have been fully migrated to Yarn, and if so, update allnpm
commands to their Yarn equivalents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/post-integration.yaml (2 hunks)
Additional comments: 2
.github/workflows/post-integration.yaml (2)
2-5: The addition of environment variables in the
env
section is consistent with the PR's objective to standardize the Nix setup across CI environments.34-44: The configuration of the
Setup nix
job correctly utilizes the environment variables and sets up Nix with the desired experimental features.
This PR fix an error that occurred for having different versions of fp-ts and io-ts in different workspaces
https://github.com/input-output-hk/marlowe-ts-sdk/actions/runs/7115510535/job/19371832332
Summary by CodeRabbit
Refactor
Chores
Documentation
.gitignore
to reflect current package management preferences.