Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-8889 - Fix ci failures #121

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

hrajchert
Copy link
Collaborator

@hrajchert hrajchert commented Dec 6, 2023

This PR fix an error that occurred for having different versions of fp-ts and io-ts in different workspaces

https://github.com/input-output-hk/marlowe-ts-sdk/actions/runs/7115510535/job/19371832332

Screenshot 2023-12-06 at 12 28 19

Summary by CodeRabbit

  • Refactor

    • Updated the continuous integration workflow to enhance testing procedures.
  • Chores

    • Improved configuration management for the build process.
  • Documentation

    • Updated .gitignore to reflect current package management preferences.

Copy link
Contributor

coderabbitai bot commented Dec 6, 2023

Walkthrough

The changes involve updates to GitHub Actions workflow configurations, with a job being renamed and the setup of Nix being modified to include specific environment variables and configurations. Additionally, .gitignore adjustments reflect a shift in package management preferences.

Changes

File Path Change Summary
.github/workflows/test-suite.yaml Renamed job and updated Nix setup with new configurations
.github/workflows/post-integration.yaml Added environment variables for Nix configuration
.gitignore Updated to reflect changes in package management files

🐇✨
In the realm of code, where actions flow,
A rabbit tweaked the CI's glow.
With Nix in place, and jobs renamed,
The workflows dance, improved and unchained. 🎉
🐇✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b757e1a and 78ef381.
Files ignored due to filter (9)
  • flake.lock
  • package-lock.json
  • package.json
  • packages/adapter/package.json
  • packages/language/core/v1/package.json
  • packages/runtime/client/rest/package.json
  • packages/runtime/core/package.json
  • packages/runtime/lifecycle/package.json
  • packages/wallet/package.json
Files selected for processing (2)
  • .github/workflows/test-suite.yaml (1 hunks)
  • .gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
  • .gitignore
Additional comments: 2
.github/workflows/test-suite.yaml (2)
  • 1-30: The changes to the GitHub Actions workflow file, including the addition of environment variables and the setup of Nix with specific configurations, appear to be correctly implemented and align with the PR's objective to fix CI failures. The use of nix develop for building and testing the project is appropriate, assuming that the project is set up to use Nix Flakes.

  • 30-30: Verify if the use of npm i && npm run build within the nix develop command is intentional, considering the shift from npm to Yarn as indicated by the changes in the .gitignore file. If the project has moved to Yarn, these commands should be updated accordingly.


Verification result:

The review comment regarding the use of npm commands in the .github/workflows/test-suite.yaml file is valid. The search results show that npm commands are still present in various documentation files, which may need to be updated if the project has fully transitioned to Yarn. However, the presence of npm commands in documentation does not necessarily indicate that they are still used in the actual build and development scripts. It is important to verify whether the CI workflow and development environment have been fully migrated to Yarn, and if so, update all npm commands to their Yarn equivalents.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 78ef381 and c9c0382.
Files selected for processing (1)
  • .github/workflows/post-integration.yaml (2 hunks)
Additional comments: 2
.github/workflows/post-integration.yaml (2)
  • 2-5: The addition of environment variables in the env section is consistent with the PR's objective to standardize the Nix setup across CI environments.

  • 34-44: The configuration of the Setup nix job correctly utilizes the environment variables and sets up Nix with the desired experimental features.

@hrajchert hrajchert merged commit c9fb933 into main Dec 6, 2023
2 checks passed
@hrajchert hrajchert deleted the hrajchert/PLT-8889-fix-ci-failures branch December 6, 2023 15:41
@nhenin nhenin added this to the Release 0.3.0-beta milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants