feat: [lw 11882] Connect DApp Explorer to DApp Radar API #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 5979448d
|
greatertomi
approved these changes
Jan 17, 2025
szymonmaslowski
force-pushed
the
feat/LW-11882-connect-to-dapp-radar
branch
from
a80d784 to
78be196
Compare
| /> | ||
| )} | ||
| {data.socialLinks.map(({ url, title }) => ( | ||
| // eslint-disable-next-line unicorn/no-null |
There was a problem hiding this comment.
Can you make itemIcon optional, so we do not need to pass null and we can remove // eslint-disable?
| @@ -15,7 +15,14 @@ export const AboutDapp: React.FC = () => { | |||
| return ( | |||
| <> | |||
| <Box my="$24"> | |||
| <Text.Body.Normal>{data?.longDescription}</Text.Body.Normal> | |||
| <Box mb="$12"> | |||
| <Text.SubHeading>{'Summary'}</Text.SubHeading> | |||
There was a problem hiding this comment.
Is this intentional to omit i18n?
pczeglik-iohk
approved these changes
Jan 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Testing
Screenshots