Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate DApp Explorer in Lace #1398

Merged
merged 8 commits into from
Jan 4, 2025
Merged

feat: integrate DApp Explorer in Lace #1398

merged 8 commits into from
Jan 4, 2025

Conversation

danielmain
Copy link
Contributor

@danielmain danielmain commented Aug 30, 2024 •
edited by szymonmaslowski
Loading

Porting dapp-explorer into lace.

Disclaimer: The code of Dapp Explorer addedin this PR is far from ideal but that is acceptable.

@danielmain danielmain added WIP Work in progress POC labels Aug 30, 2024
@danielmain danielmain self-assigned this Aug 30, 2024
@danielmain danielmain requested a review from a team as a code owner August 30, 2024 11:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@rhyslbw rhyslbw marked this pull request as draft September 13, 2024 09:04
@szymonmaslowski szymonmaslowski force-pushed the chore/LW-11272-port-dapp-explorer-components branch from 6c06766 to 94fb163 Compare December 18, 2024 12:40
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Dec 18, 2024 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 732556b0

passed failed skipped flaky total result
Total 33 0 4 0 37 ✅

@DominikGuzei DominikGuzei force-pushed the chore/LW-11272-port-dapp-explorer-components branch from 94fb163 to 063bfb0 Compare December 19, 2024 12:12
@szymonmaslowski szymonmaslowski force-pushed the chore/LW-11272-port-dapp-explorer-components branch 2 times, most recently from 08439b6 to 732556b Compare January 3, 2025 23:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@szymonmaslowski szymonmaslowski marked this pull request as ready for review January 3, 2025 23:15
@szymonmaslowski szymonmaslowski changed the title [LW-11272] - Spike - PoC to explore how to integrate DApp Explorer in Lace feat: integrate DApp Explorer in Lace Jan 4, 2025
@szymonmaslowski szymonmaslowski merged commit 42a560c into main Jan 4, 2025
31 of 40 checks passed
@szymonmaslowski szymonmaslowski deleted the chore/LW-11272-port-dapp-explorer-components branch January 4, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonmaslowski szymonmaslowski szymonmaslowski approved these changes

Assignees
No one assigned
Labels
POC WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielmain @pczeglik-iohk @szymonmaslowski @DominikGuzei