Fix stack overflow by adding a missing bang #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
requested review from
denisshevchenko and
oneEdoubleD
as code owners
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make mrBliss a reviewer |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 11, 2019
479: Fix stack overflow by adding a missing bang r=dcoutts a=mrBliss The local `qProc` function in `Cardano.BM.Backend.Switchboard` loops by calling itself recursively, passing in the same `MVar MessageCounter` each time. However, `MessageCounter` was missing a bang on its `mcCountersMap` field, which contains `HM.HashMap Text Word64`. Even though the `HashMap` is a strict one, if you don't force it, you're still accumulating thunks. And as the `MVar` containing the `MessageCounter` was passed recursively, this resulted in a stack overflow instead of running out of (heap) memory. Fix it by adding the missing bang. This should fix IntersectMBO/cardano-node#370. Co-authored-by: Thomas Winant <[email protected]>
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 11, 2019
479: Fix stack overflow by adding a missing bang r=CodiePP a=mrBliss The local `qProc` function in `Cardano.BM.Backend.Switchboard` loops by calling itself recursively, passing in the same `MVar MessageCounter` each time. However, `MessageCounter` was missing a bang on its `mcCountersMap` field, which contains `HM.HashMap Text Word64`. Even though the `HashMap` is a strict one, if you don't force it, you're still accumulating thunks. And as the `MVar` containing the `MessageCounter` was passed recursively, this resulted in a stack overflow instead of running out of (heap) memory. Fix it by adding the missing bang. This should fix IntersectMBO/cardano-node#370. Co-authored-by: Thomas Winant <[email protected]>
The local `qProc` function in `Cardano.BM.Backend.Switchboard` loops by calling itself recursively, passing in the same `MVar MessageCounter` each time. However, `MessageCounter` was missing a bang on its `mcCountersMap` field, which contains `HM.HashMap Text Word64`. Even though the `HashMap` is a strict one, if you don't force it, you're still accumulating thunks. And as the `MVar` containing the `MessageCounter` was passed recursively, this resulted in a stack overflow instead of running out of (heap) memory. Fix it by adding the missing bang. This should fix IntersectMBO/cardano-node#370. Signed-off-by: Alexander Diemand <[email protected]>
CodiePP
force-pushed
the
mrBliss/fix-stack-overflow
branch
from
327bdf4 to
da2001b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local
qProcfunction inCardano.BM.Backend.Switchboardloops bycalling itself recursively, passing in the same
MVar MessageCountereachtime. However,
MessageCounterwas missing a bang on itsmcCountersMapfield, which contains
HM.HashMap Text Word64. Even though theHashMapis astrict one, if you don't force it, you're still accumulating thunks. And as
the
MVarcontaining theMessageCounterwas passed recursively, thisresulted in a stack overflow instead of running out of (heap) memory.
Fix it by adding the missing bang.
This should fix IntersectMBO/cardano-node#370.