Fix -inplace issue with ghc 9.8.1 boot packages
#2161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-pkgs # Conflicts: # overlays/bootstrap.nix # test/plugin/default.nix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -88,6 +88,7 @@ in { | |||
| # Returns true iff this derivation's version is greater than or equal to ver. | |||
| versionAtLeast = ver: !versionLessThan ver; | |||
| fromUntil = start: end: final.lib.optional (versionAtLeast start && versionLessThan end); | |||
| from = start: final.lib.optional (versionAtLeast start); | |||
There was a problem hiding this comment.
[diff] reported by reviewdog 🐶
Suggested change
| from = start: final.lib.optional (versionAtLeast start); |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to find a fix for #2153 and #2155 that still allows
reinstallableLibGhc = true.The problem seems to be that:
-inplace.make-install-planwith theghc-pkg listin scope and the planner finds-inplaceversions of the packages and includes them in the plan.-inplaceversion of the packages, instead of getting them from hackage.In #2158 we set
reinstallableLibGhc = falsefor ghc 9.8.1. It would be good to avoid this.One solution might be to tell the planner to choose hackage versions of the packages, but I don't think this will work for the
ghcpackage because it is not in hackage.@andreabedini is there a way we could deal with the
-inplacepackages in the plan as if they were did not have the-inplacesuffix?