Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging of components into "all" #42

Closed
rvl opened this issue Feb 1, 2019 · 1 comment
Closed

Fix merging of components into "all" #42

rvl opened this issue Feb 1, 2019 · 1 comment
Assignees
@rvl
Labels
bug Something isn't working

Comments

@rvl
Copy link
Contributor

rvl commented Feb 1, 2019 •
edited
Loading

At present, the only component option merged into package.components.all is depends.
Therefore it won't work if there are system libraries, etc.

Need to figure out a way of using mkMerge from the NixOS module system to do this.

Some first attempts are here:
d1a3c56
@rvl rvl self-assigned this Feb 1, 2019
@rvl rvl mentioned this issue Feb 1, 2019
Merged
4 tasks
@rvl
Copy link
Contributor Author

rvl commented Feb 1, 2019

Additionally, the current depends concatenation logic is buggy because it includes the library itself as a depend of the "all" component.

@rvl rvl added the bug Something isn't working label Feb 1, 2019
ElvishJerricco added a commit to ElvishJerricco/haskell.nix that referenced this issue Feb 2, 2019
@ElvishJerricco
Use mkmerge for the all component. [Fixes input-output-hk#42]
8a03c5b
@rvl rvl mentioned this issue Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvl rvl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rvl