feat: use pool delegation endpoint for constructing drep tx no matter the wallet type #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend reviewing with the "hide whitespace" option |
przemyslaw-wlodek
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Nice job @szymonmaslowski! I left just one comment about error log.
michalrus
reviewed
Dec 11, 2024
szymonmaslowski
force-pushed
the
feat/pool-delegation-endpoint-for-drep-tx-construction
branch
from
f976c42 to
6cdd7ba
Compare
szymonmaslowski
deleted the
feat/pool-delegation-endpoint-for-drep-tx-construction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for cardano-foundation/cardano-wallet#4872
https://input-output.atlassian.net/browse/LW-11980
The constructTransaction endpoint of CWB seems to fail on vote delegation for some of mnemonic wallets. We can mitigate the problem by using a pool delegation endpoint, as we do for hardware wallets.
The PR targeted to release/7.0.1 temporarily until we have a next release branch.