Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-788][DEBT] - Research how to use JSCSS instead css files in Daedalus #2823

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

renanvalentin
Copy link
Contributor

@renanvalentin renanvalentin commented Jan 19, 2022

Proof of concept for CSS-IN-JSS. Each commit has a different proposal.

Chakra-UI
8da492f

Chakra-UI - cleaner
e70a04f

Emotion.JS
bfe2b17

Todos

  • TODO

Screenshots

Runtime test on Stake Pools using Chakra-UI

Screen Shot 2022-01-19 at 08 59 12

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@renanvalentin renanvalentin force-pushed the chore/ddw-788-jscss branch 2 times, most recently from 7896501 to d1d3dc8 Compare January 19, 2022 12:04
@renanvalentin renanvalentin changed the title [DDW-788] Chakra-ui [DEBT] - Research how to use JSCSS instead css files in Daedalus Jan 19, 2022
@renanvalentin renanvalentin changed the title [DEBT] - Research how to use JSCSS instead css files in Daedalus [DDW-788][DEBT] - Research how to use JSCSS instead css files in Daedalus Jan 19, 2022
@renanvalentin renanvalentin force-pushed the chore/ddw-788-jscss branch 5 times, most recently from 6bc45dc to 538deec Compare January 19, 2022 20:03
@renanvalentin renanvalentin force-pushed the chore/ddw-788-jscss branch 2 times, most recently from 0770010 to b8df840 Compare February 8, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant