simple metadata format in some transaction endpoints #3253

paolino · 2022-04-26T15:44:02Z

We implement support for transaction creation (old and new)
we implement a query parameter simple-metadata on get transaction and list transactions to select the new format in the response
we implement a switch in the CLI commands get and list to support the new format in the output
we use oneOf openapi combinator to document the possibility of the two formats for the same endpoints

User facing changes

implement additional simple metadata format in get and list transaction output (simple-metadata flag)
implement additional simple metadata format in transaction creation (no flag needed)

Issue Number

ADP-1596

jonathanknowles

Hi @paolino

Many thanks for making this PR!

I've not had a chance to look through all the functionality yet, but there are a couple of things to fix:

The latency benchmark currently doesn't build, because Link.getTransaction now takes an extra argument. If you're typically building with cabal build all, then you might want to run cabal configure --enable-benchmarks. This will make sure that cabal build all also builds the benchmarks! (I was also caught out by this the other day...)
There are some import and formatting issues that we should fix.

I created PR #3257 with suggested fixes for both of these issues. If you're okay with the commits in that PR, please feel free to squash them into your own branch, or cherry-pick them if you prefer. 👍🏻

paolino · 2022-04-28T07:06:24Z

Hi @paolino

Many thanks for making this PR!

I've not had a chance to look through all the functionality yet, but there are a couple of things to fix:
1. The latency benchmark currently doesn't build, because `Link.getTransaction` now takes an extra argument. If you're typically building with `cabal build all`, then you might want to run `cabal configure --enable-benchmarks`. This will make sure that `cabal build all` also builds the benchmarks! (I was also caught out by this the other day...)

2. There are some import and formatting issues that we should fix.
I created PR #3257 with suggested fixes for both of these issues. If you're okay with the commits in that PR, please feel free to squash them into your own branch, or cherry-pick them if you prefer. 👍🏻

Thanks @jonathanknowles for the fixes!

paolino · 2022-04-28T07:11:18Z

User-facing changes

simple (untyped) metadata format is supported along with the old one in get and list transaction output (see simple-metadata flag)
simple (untyped) metadata format is supported along with the old one in transaction creation (no flag needed)

lib/cli/src/Cardano/CLI.hs

paolino · 2022-05-03T14:08:16Z

bors try

iohk-bors · 2022-05-03T15:48:39Z

try

Build failed:

ci/hydra-build:required

  src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2200:65: 
  1) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, currency
       uncaught exception: RequestException
       ClientError (Object (fromList [("code",String "redeemer_script_failure"),("message",String "I was unable to assign execution units to one of your redeemers: minting(f9633e6522060ad2989ad8582e4498f7ef544c56da4ff470f903b73b); Its execution is failing with the following error: ValidationFailedV1 (CodecError (DeserialiseFailure 3280 \"NotEnoughSpace (0x0000004203092ce0,S {currPtr = 0x0000004203092cdf, usedBits = 6})\")) [].")]))

  To rerun use: --match "/API Specifications/NEW_SHELLEY_TRANSACTIONS/Plutus scenarios/currency/"

  src/Test/Integration/Scenario/CLI/Shelley/Wallets.hs:735:5: 
  2) CLI Specifications, SHELLEY_CLI_WALLETS, WALLETS_UTXO_02 - Utxo statistics works properly
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_WALLETS/WALLETS_UTXO_02 - Utxo statistics works properly/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:98:5: 
  3) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_01x - Restoration from account public key preserves funds
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_01x - Restoration from account public key preserves funds/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:156:9: 
  4) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_03 - Cannot do operations requiring private key, Cannot send tx
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_03 - Cannot do operations requiring private key/Cannot send tx/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:221:9: 
  5) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_04 - Can manage HW wallet the same way as others, Can get tx fee
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

sevanspowell · 2022-05-04T01:17:21Z

bors try

iohk-bors · 2022-05-04T02:05:24Z

try

Build failed:

ci/hydra-build:required


       Waited longer than 90s to resolve action: "metadata is fetched".
       expected: [PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}]
        but got: []

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

  src/Test/Integration/Scenario/CLI/Shelley/Wallets.hs:735:5:
  3) CLI Specifications, SHELLEY_CLI_WALLETS, WALLETS_UTXO_02 - Utxo statistics works properly
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_WALLETS/WALLETS_UTXO_02 - Utxo statistics works properly/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:98:5:
  4) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_01x - Restoration from account public key preserves funds
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_01x - Restoration from account public key preserves funds/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:156:9:
  5) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_03 - Cannot do operations requiring private key, Cannot send tx
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_03 - Cannot do operations requiring private key/Cannot send tx/"

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:221:9:
  6) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_04 - Can manage HW wallet the same way as others, Can get tx fee
       uncaught exception: IOException of type UserError
       user error (No more faucet wallet available in MVar!)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_04 - Can manage HW wallet the same way as others/Can get tx fee/"

sevanspowell · 2022-05-04T06:36:46Z

bors r+

iohk-bors · 2022-05-04T06:36:49Z

👎 Rejected by code reviews

sevanspowell · 2022-05-04T06:36:57Z

bors try

iohk-bors · 2022-05-04T07:14:58Z

try

Build failed:

ci/hydra-build:required

  src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2200:65: 
  1) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, withdrawal
       uncaught exception: ProcessHasExited
       ProcessHasExited "cardano-cli failed: Command failed: transaction submit  Error: Error while submitting tx: ShelleyTxValidationError ShelleyBasedEraAlonzo (ApplyTxError [DelegsFailure (DelplFailure (DelegFailure (StakeKeyAlreadyRegisteredDELEG (ScriptHashObj (ScriptHash \"1b8374d0b294a4a3399ff25f06a0707b16214f1e9b67cf89ba2454a6\")))))])\n" (ExitFailure 1)

  To rerun use: --match "/API Specifications/NEW_SHELLEY_TRANSACTIONS/Plutus scenarios/withdrawal/"

  src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2200:65: 
  2) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, currency
       uncaught exception: RequestException
       ClientError (Object (fromList [("code",String "redeemer_script_failure"),("message",String "I was unable to assign execution units to one of your redeemers: minting(ad4e57f412ab06b6a9c64ff6f1f7e448bc873726c132085de21e1495); Its execution is failing with the following error: ValidationFailedV1 (CodecError (DeserialiseFailure 3280 \"NotEnoughSpace (0x0000004209304ce0,S {currPtr = 0x0000004209304cdf, usedBits = 6})\")) [].")]))

  To rerun use: --match "/API Specifications/NEW_SHELLEY_TRANSACTIONS/Plutus scenarios/currency/"

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:1224:25: 
  3) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools
       While verifying value:
         ( Status
             { statusCode = 200
             , statusMessage = "OK"
             }
         , Right
             [ ApiStakePool
                 { id = ApiT
                     ( PoolId
                         { getPoolId = "ì(ó=ËæÖ@
                         \x1e^3\x9bÐd|\x9sÊl\xcùÂ»æ\x83\x8dÆ" }
                     )
                 , metrics = ApiStakePoolMetrics
                     { nonMyopicMemberRewards = Quantity 668323983491327
                     , relativeStake = Quantity
                         ( Percentage
                             ( 2993 % 10000 )
                         )
                     , saturation = 0.8980475865400197
                     , producedBlocks = Quantity 608
                     }
                 , metadata = Just
                     ( ApiT
                         ( StakePoolMetadata
                             { ticker = StakePoolTicker
                                 { unStakePoolTicker = "GPA" }
                             , name = "Genesis Pool A"
                             , description = Nothing
                             , homepage = "https://iohk.io"
                             }
                         )
                     )
                 , cost = Quantity 0
                 , margin = Quantity
                     ( Percentage
                         ( 1 % 10 )
                     )
                 , pledge = Quantity 2000000000000
                 , retirement = Nothing
                 , flags = []
                 }
             , ApiStakePool
                 { id = ApiT
                     ( PoolId
                         { getPoolId = "\x1b=Á\x9cj¸\x9e¯ü\x85\x1óu»\x3Á\x1bøí]\x1876±Ø\x4\x13Ö" }
                     )
                 , metrics = ApiStakePoolMetrics
                     { nonMyopicMemberRewards = Quantity 647546788062600
                     , relativeStake = Quantity
                         ( Percentage
                             ( 167 % 1000 )
                         )
                     , saturation = 0.5011021655687948
                     , producedBlocks = Quantity 264
                     }
                 , metadata = Just
                     ( ApiT
                         ( StakePoolMetadata
                             { ticker = StakePoolTicker
                                 { unStakePoolTicker = "GPB" }
                             , name = "Genesis Pool B"
                             , description = Nothing
                             , homepage = "https://iohk.io"
                             }
                         )
                     )
                 , cost = Quantity 0
                 , margin = Quantity
                     ( Percentage
                         ( 1 % 10 )
                     )
                 , pledge = Quantity 1000000000000
                 , retirement = Just
                     ( ApiEpochInfo
                         { epochNumber = ApiT
                             ( EpochNo
                                 { unEpochNo = 100000 }
                             )
                         , epochStartTime = 2022 - 05 - 27 10 : 29 : 36 UTC
                         }
                     )
                 , flags = []
                 }
             , ApiStakePool
                 { id = ApiT
                     ( PoolId
                         { getPoolId = "»\x11L³}uú\x5&\x3(Â5£Úâ\x95£=\xb¦t¥ë\x1e>V\x8e" }
                     )
                 , metrics = ApiStakePoolMetrics
                     { nonMyopicMemberRewards = Quantity 596314992365140
                     , relativeStake = Quantity
                         ( Percentage
                             ( 359 % 1000 )
                         )
                     , saturation = 1.0768944503297566
                     , producedBlocks = Quantity 540
                     }
                 , metadata = Just
                     ( ApiT
                         ( StakePoolMetadata
                             { ticker = StakePoolTicker
                                 { unStakePoolTicker = "GPD" }
                             , name = "Genesis Pool D"
                             , description = Just "Lorem Ipsum Dolor Sit Amet."
                             , homepage = "https://iohk.io"
                             }
                         )
                     )
                 , cost = Quantity 0
                 , margin = Quantity
                     ( Percentage
                         ( 1 % 10 )
                     )
                 , pledge = Quantity 1000000000000
                 , retirement = Just
                     ( ApiEpochInfo
                         { epochNumber = ApiT
                             ( EpochNo
                                 { unEpochNo = 1000000 }
                             )
                         , epochStartTime = 2022 - 12 - 21 18 : 29 : 36 UTC
                         }
                     )
                 , flags = []
                 }
             ]
         )
       
       Waited longer than 90s to resolve action: "metadata is fetched".
       expected: [PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}]
        but got: []

sevanspowell · 2022-05-04T07:28:02Z

I cannot reproduce these failures locally (unless I run the whole suite, individually they pass). I'm going to keep bors trying for a bit.

Perhaps this is a resource issue?

jonathanknowles · 2022-05-10T04:54:04Z

Hi @paolino

Regarding:

Though I do have some reservations though about the use of Bool in certain function type signatures. I think this may contribute to "Boolean blindness", particularly at call sites, where I think it might be difficult for readers to determine what the intended semantics are (see review comments). Given that we have a rich TxMetadataSchema type available, I think we can use that instead in most cases. (This also applies to integration tests.)

I've been preparing a small PR with proposed fixes. I'll let you know when it's ready to review.

As promised, I've made these proposed changes in #3270.

…simple-metadata Use `TxMetadataSchema` in preference to `Bool` for function parameters.

jonathanknowles

LGTM!

paolino · 2022-05-10T10:21:08Z

LGTM!

But not to CI !

paolino · 2022-05-10T10:26:26Z

   test/unit/Cardano/Wallet/Api/Server/TlsSpec.hs:118:13: 
  1) Cardano.Wallet.Api.Server.Tls, TLS Client Authentication, Deny client with wrong certificate if TLS is enabled
       predicate failed on expected exception: HttpException (HttpExceptionRequest Request {
         host                 = "127.0.0.1"
         port                 = 58601
         secure               = True
         requestHeaders       = []
         path                 = "/"
         queryString          = ""
         method               = "GET"
         proxy                = Nothing
         rawBody              = False
         redirectCount        = 10
         responseTimeout      = ResponseTimeoutDefault
         requestVersion       = HTTP/1.1
       }
        (InternalException Network.Socket.recvBuf: invalid argument (Invalid argument)))

  To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

this passes on penguins branch

iohk-bors · 2022-05-10T12:26:02Z

try

Build failed:

ci/hydra-build:required

lib/core-integration/src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs

lib/core/src/Cardano/Wallet/Api/Client.hs

lib/core/src/Cardano/Wallet/Api/Types/SchemaMetadata.hs

…/Transactions.hs Co-authored-by: Heinrich Apfelmus <[email protected]>

paolino · 2022-05-10T13:55:36Z

fix ((bors r+) >>)

piotr-iohk · 2022-05-10T18:28:56Z

bors r+

3253: simple metadata format in some transaction endpoints r=piotr-iohk a=paolino - We implement support for transaction creation (old and new) - we implement a query parameter `simple-metadata` on `get transaction` and `list transactions` to select the new format in the response - we implement a switch in the CLI commands get and list to support the new format in the output - we use `oneOf ` openapi combinator to document the possibility of the two formats for the same endpoints ### Issue Number ADP-1596 3269: Validity interval fix r=paweljakubas a=paweljakubas  - [x] simplyfying interval logic - [x] enhaning integration testing ### Comments  ### Issue Number adp-1738  Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>

sevanspowell · 2022-05-11T01:09:50Z

Seems build timed out but bors didn't notice 🤔

https://hydra.iohk.io/eval/1226372

sevanspowell · 2022-05-11T01:09:57Z

bors r-

iohk-bors · 2022-05-11T01:09:58Z

Canceled.

sevanspowell · 2022-05-11T01:10:09Z

bors r+

3253: simple metadata format in some transaction endpoints r=sevanspowell a=paolino - We implement support for transaction creation (old and new) - we implement a query parameter `simple-metadata` on `get transaction` and `list transactions` to select the new format in the response - we implement a switch in the CLI commands get and list to support the new format in the output - we use `oneOf ` openapi combinator to document the possibility of the two formats for the same endpoints ### Issue Number ADP-1596 3269: Validity interval fix r=paweljakubas a=paweljakubas  - [x] simplyfying interval logic - [x] enhaning integration testing ### Comments  ### Issue Number adp-1738  Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>

iohk-bors · 2022-05-11T03:25:32Z

Build failed (retrying...):

ci/hydra-build:required

3253: simple metadata format in some transaction endpoints r=sevanspowell a=paolino - We implement support for transaction creation (old and new) - we implement a query parameter `simple-metadata` on `get transaction` and `list transactions` to select the new format in the response - we implement a switch in the CLI commands get and list to support the new format in the output - we use `oneOf ` openapi combinator to document the possibility of the two formats for the same endpoints ### Issue Number ADP-1596 Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>

iohk-bors · 2022-05-11T06:49:34Z

Build failed:

ci/hydra-build:required

sevanspowell · 2022-05-11T06:58:26Z

bors r+

3253: simple metadata format in some transaction endpoints r=sevanspowell a=paolino - We implement support for transaction creation (old and new) - we implement a query parameter `simple-metadata` on `get transaction` and `list transactions` to select the new format in the response - we implement a switch in the CLI commands get and list to support the new format in the output - we use `oneOf ` openapi combinator to document the possibility of the two formats for the same endpoints ### Issue Number ADP-1596 Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Paolo Veronelli <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>

iohk-bors · 2022-05-11T07:46:36Z

Build failed:

ci/hydra-build:required

jonathanknowles · 2022-05-11T12:05:23Z

Will merge manually, in accordance with decision recorded here: https://md.adrestia.iohkdev.io/s/jo5Of1Qli#

…simple-metadata

paolino requested review from jonathanknowles, Anviking, sevanspowell, paweljakubas and piotr-iohk April 26, 2022 15:44

paolino changed the title ~~support simple metadata format in some transaction endpoints~~ simple metadata format in some transaction endpoints Apr 26, 2022

jonathanknowles mentioned this pull request Apr 28, 2022

Fixes for ADP-1596 #3257

Merged

jonathanknowles suggested changes Apr 28, 2022

View reviewed changes

paolino marked this pull request as ready for review May 2, 2022 06:46

paolino self-assigned this May 2, 2022

paolino force-pushed the paolino/ADP-1596/simple-metadata branch 4 times, most recently from e0daedf to afecfb1 Compare May 3, 2022 10:19

Unisay reviewed May 3, 2022

View reviewed changes

lib/cli/src/Cardano/CLI.hs Outdated Show resolved Hide resolved

Unisay reviewed May 3, 2022

View reviewed changes

lib/cli/src/Cardano/CLI.hs Show resolved Hide resolved

iohk-bors bot added a commit that referenced this pull request May 3, 2022

Try #3253:

da4e538

iohk-bors bot added a commit that referenced this pull request May 4, 2022

Try #3253:

b3c94e8

iohk-bors bot added a commit that referenced this pull request May 4, 2022

Try #3253:

d6fbd40

jonathanknowles and others added 2 commits May 10, 2022 16:13

Merge pull request #3270 from input-output-hk/jonathanknowles/ADP-1596/…

7a42cb2

…simple-metadata Use `TxMetadataSchema` in preference to `Bool` for function parameters.

remove duplicate MetadataSchema datatype

00213c9

jonathanknowles self-requested a review May 10, 2022 09:09

jonathanknowles approved these changes May 10, 2022

View reviewed changes

iohk-bors bot added a commit that referenced this pull request May 10, 2022

Try #3253:

3720a6e

HeinrichApfelmus approved these changes May 10, 2022

View reviewed changes

paolino and others added 2 commits May 10, 2022 15:09

Update lib/core-integration/src/Test/Integration/Scenario/CLI/Shelley…

15a841e

…/Transactions.hs Co-authored-by: Heinrich Apfelmus <[email protected]>

apply stylistic suggestions

c1e8181

jonathanknowles merged commit 1f76c11 into master May 11, 2022

jonathanknowles deleted the paolino/ADP-1596/simple-metadata branch May 11, 2022 12:05

WilliamKingNoel-Bot pushed a commit that referenced this pull request May 11, 2022

docs: Merge pull request #3253 from input-output-hk/paolino/ADP-1596/…

f6dd2eb

…simple-metadata

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simple metadata format in some transaction endpoints #3253

simple metadata format in some transaction endpoints #3253

paolino commented Apr 26, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

paolino commented Apr 28, 2022

paolino commented Apr 28, 2022

paolino commented May 3, 2022

iohk-bors bot commented May 3, 2022 •

edited by Anviking

Loading

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022 •

edited by Anviking

Loading

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022 •

edited by Anviking

Loading

sevanspowell commented May 4, 2022

jonathanknowles commented May 10, 2022 •

edited

Loading

jonathanknowles left a comment

paolino commented May 10, 2022

paolino commented May 10, 2022

iohk-bors bot commented May 10, 2022

paolino commented May 10, 2022

piotr-iohk commented May 10, 2022

sevanspowell commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

iohk-bors bot commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

jonathanknowles commented May 11, 2022

simple metadata format in some transaction endpoints #3253

simple metadata format in some transaction endpoints #3253

Conversation

paolino commented Apr 26, 2022 • edited Loading

User facing changes

Issue Number

jonathanknowles left a comment • edited Loading

Choose a reason for hiding this comment

paolino commented Apr 28, 2022

paolino commented Apr 28, 2022

User-facing changes

paolino commented May 3, 2022

iohk-bors bot commented May 3, 2022 • edited by Anviking Loading

try

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022 • edited by Anviking Loading

try

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022

sevanspowell commented May 4, 2022

iohk-bors bot commented May 4, 2022 • edited by Anviking Loading

try

sevanspowell commented May 4, 2022

jonathanknowles commented May 10, 2022 • edited Loading

jonathanknowles left a comment

Choose a reason for hiding this comment

paolino commented May 10, 2022

paolino commented May 10, 2022

iohk-bors bot commented May 10, 2022

try

paolino commented May 10, 2022

piotr-iohk commented May 10, 2022

sevanspowell commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

iohk-bors bot commented May 11, 2022

sevanspowell commented May 11, 2022

iohk-bors bot commented May 11, 2022

jonathanknowles commented May 11, 2022

paolino commented Apr 26, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

iohk-bors bot commented May 3, 2022 •

edited by Anviking

Loading

iohk-bors bot commented May 4, 2022 •

edited by Anviking

Loading

iohk-bors bot commented May 4, 2022 •

edited by Anviking

Loading

jonathanknowles commented May 10, 2022 •

edited

Loading