Fixes for ADP-1596 #3257
Merged
Fixes for ADP-1596 #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes all trailing whitespace from the files affected by PR 2353.
We normally only use a single blank line between definitions: https://input-output-hk.github.io/adrestia/code/Coding-Standards#use-only-a-single-blank-line-between-top-level-definitions
We usually use 4 spaces for indentation: https://input-output-hk.github.io/adrestia/code/Coding-Standards#editor-configuration-via-editorconfig We also avoid variable-length indentation where possible: https://input-output-hk.github.io/adrestia/code/Coding-Standards#avoid-variable-length-indentation
This commit:
1. Separates imports into two sections:
- Non-qualified imports
- Qualified imports
2. Turns implicit imports into explicit imports.
3. Runs stylish-haskell to sort the imports into alphabetical order:
```
stylish-haskell -i `git ls-files -- '*.hs'`
```
(This is normally run by CI, so the build will fail without it.)
We usually also require that imports are imported explicitly:
https://input-output-hk.github.io/adrestia/code/Coding-Standards#we-use-explicit-imports-by-default-and-favor-qualified-imports-for-ambiguous-functions
The motivation is to help with code readability. (When reviewing the
code in a browser, it's not always obvious where a symbol has come
from.)
paolino
added a commit
that referenced
this pull request
May 2, 2022
…simple-metadata Fixes for ADP-1596
paolino
added a commit
that referenced
this pull request
May 2, 2022
…simple-metadata Fixes for ADP-1596
paolino
added a commit
that referenced
this pull request
May 2, 2022
…simple-metadata Fixes for ADP-1596
paolino
added a commit
that referenced
this pull request
May 3, 2022
…simple-metadata Fixes for ADP-1596
paolino
added a commit
that referenced
this pull request
May 6, 2022
…simple-metadata Fixes for ADP-1596
Anviking
pushed a commit
that referenced
this pull request
May 9, 2022
…simple-metadata Fixes for ADP-1596
paolino
added a commit
that referenced
this pull request
May 13, 2022
…simple-metadata Fixes for ADP-1596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1596 / #3253
Summary
This PR contains some suggested fixes for PR #3253.