Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Bump cardano-crypto #3980

Merged
merged 3 commits into from
Dec 22, 2018
Merged

Bump cardano-crypto #3980

merged 3 commits into from
Dec 22, 2018

Conversation

akegalj
Copy link
Contributor

@akegalj akegalj commented Dec 21, 2018

Fixes deriveXPub: bip32 hd wallet public key derivation
IntersectMBO/cardano-crypto#52

Description

This is a bump of cardano-crypto bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task on cardano-wallet cardano-foundation/cardano-wallet#41

Linked issue

cardano-foundation/cardano-wallet#41

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@akegalj akegalj requested review from angerman and KtorZ December 21, 2018 09:23
Fixes deriveXPub: bip32 hd wallet public key derivation
IntersectMBO/cardano-crypto#52
@akegalj akegalj force-pushed the akegalj/bump-cardano-crypto branch from 087d96c to dc7e117 Compare December 21, 2018 09:27
@akegalj akegalj requested review from vincenthz and removed request for angerman December 21, 2018 09:27
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KtorZ
Copy link
Contributor

KtorZ commented Dec 21, 2018

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 21, 2018
3980: Bump cardano-crypto r=KtorZ a=akegalj

Fixes deriveXPub: bip32 hd wallet public key derivation
IntersectMBO/cardano-crypto#52

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

This is a bump of `cardano-crypto` bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task on `cardano-wallet` cardano-foundation/cardano-wallet#41

## Linked issue

<!--- Put here the relevant issue from YouTrack -->
cardano-foundation/cardano-wallet#41


Co-authored-by: Ante Kegalj <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2018

Timed out

@KtorZ
Copy link
Contributor

KtorZ commented Dec 22, 2018

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 22, 2018
3980: Bump cardano-crypto r=KtorZ a=akegalj

Fixes deriveXPub: bip32 hd wallet public key derivation
IntersectMBO/cardano-crypto#52

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

This is a bump of `cardano-crypto` bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task on `cardano-wallet` cardano-foundation/cardano-wallet#41

## Linked issue

<!--- Put here the relevant issue from YouTrack -->
cardano-foundation/cardano-wallet#41


Co-authored-by: Ante Kegalj <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 22, 2018

@iohk-bors iohk-bors bot merged commit d234b85 into develop Dec 22, 2018
@iohk-bors iohk-bors bot deleted the akegalj/bump-cardano-crypto branch December 22, 2018 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants