This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deriveXPub: bip32 hd wallet public key derivation IntersectMBO/cardano-crypto#52
akegalj
force-pushed
the
akegalj/bump-cardano-crypto
branch
from
December 21, 2018 09:27
087d96c
to
dc7e117
Compare
angerman
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KtorZ
approved these changes
Dec 21, 2018
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 21, 2018
3980: Bump cardano-crypto r=KtorZ a=akegalj Fixes deriveXPub: bip32 hd wallet public key derivation IntersectMBO/cardano-crypto#52 ## Description <!--- A brief description of this PR and the problem is trying to solve --> This is a bump of `cardano-crypto` bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task on `cardano-wallet` cardano-foundation/cardano-wallet#41 ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#41 Co-authored-by: Ante Kegalj <[email protected]>
Timed out |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 22, 2018
3980: Bump cardano-crypto r=KtorZ a=akegalj Fixes deriveXPub: bip32 hd wallet public key derivation IntersectMBO/cardano-crypto#52 ## Description <!--- A brief description of this PR and the problem is trying to solve --> This is a bump of `cardano-crypto` bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task on `cardano-wallet` cardano-foundation/cardano-wallet#41 ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#41 Co-authored-by: Ante Kegalj <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deriveXPub: bip32 hd wallet public key derivation
IntersectMBO/cardano-crypto#52
Description
This is a bump of
cardano-crypto
bug IntersectMBO/cardano-crypto#52 . It was discovered as a part of a task oncardano-wallet
cardano-foundation/cardano-wallet#41Linked issue
cardano-foundation/cardano-wallet#41
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+
to merge this PR. For more information, seedocs/how-to/bors.md
.