provide a reference for the cost model keys #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/specify_cost_model_keys_for_cddl
branch
from
6299d3e
to
61f59c8
Compare
michaelpj
reviewed
Feb 1, 2022
| ; The values in the serialization are assumed to be ordered | ||
| ; lexicographically by their correpsonding key value. | ||
| ; The key values can be found in the Plutus repository: | ||
| ; https://github.com/input-output-hk/plutus/blob/748a0c62de00f9944100b616367d9b6549346022/plutus-core/plutus-core/test/CostModelInterface/defaultCostModelParams.json |
There was a problem hiding this comment.
I'm less comfortable with referencing this externally. That's data that we use for testing, not anything that we're committing to be used as reference. If you're okay with that then fine.
Also there is a reference here: https://plutus.readthedocs.io/en/latest/reference/cost-model-parameters.html
There was a problem hiding this comment.
I'm glad you said something, I must have misunderstood. Would you prefer if I add the text file back, the one which just lists the key names?
There was a problem hiding this comment.
I think it's whichever you're more comfortable with the risks for:
- The text file we'll have to remember to keep up to date
- The reference to the test file might become wrong, or we might move it, or who knows
So that the CDDL spec can reference it. closes #2634
JaredCorduan
force-pushed
the
jc/specify_cost_model_keys_for_cddl
branch
from
61f59c8
to
5bc6b77
Compare
nc6
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a reference for the cost model keys so that the CDDL spec can reference it.
closes #2634