Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

important to define the key names for costModel #2634

Closed
ashisherc opened this issue Jan 26, 2022 · 2 comments · Fixed by #2635
Closed

important to define the key names for costModel #2634

ashisherc opened this issue Jan 26, 2022 · 2 comments · Fixed by #2635
Labels

Comments

@ashisherc
Copy link

ashisherc commented Jan 26, 2022

The cost model is used for computing script integrity hash, which is done by sorting the cost model values lexicographically by key names. The key names are unknown until we see find the key names as used by the cli when querying proto params. Since script integrity hash is also computed in other languages, it is required to define the key names in the CDDL spec.

https://github.com/input-output-hk/cardano-ledger/blob/01e362881823e30cf69907c65b038dc34f9bdd20/eras/alonzo/test-suite/cddl-files/alonzo.cddl#L312

@ashisherc
Copy link
Author

cc: @JaredCorduan

@JaredCorduan
Copy link
Contributor

I agree, there should be a comment in the CDDL spec which provides this information.

JaredCorduan pushed a commit that referenced this issue Jan 26, 2022
so that the CDDL can refence it.

closes #2634
JaredCorduan pushed a commit that referenced this issue Jan 31, 2022
So that the CDDL spec can reference it.

closes #2634
JaredCorduan pushed a commit that referenced this issue Feb 2, 2022
So that the CDDL spec can reference it.

closes #2634
@nc6 nc6 closed this as completed in #2635 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants