-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/phpstan #172
Feature/phpstan #172
Conversation
Co-authored-by: Thorsten Frommen <[email protected]> Signed-off-by: Christian Leucht <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% convinced not to enforce a file naming convention, but I won't block this either. In any case, the documentation needs to be updated.
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Thorsten Frommen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds
phpstan
to the reusable workflowstatic-analysis-php.yml
by detecting the the configuration file. Additionally there is now a detection forpsalm.xml
before executing the binary.