Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/phpstan #172

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Feature/phpstan #172

merged 8 commits into from
Jan 7, 2025

Conversation

Chrico
Copy link
Member

@Chrico Chrico commented Jan 6, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR adds phpstan to the reusable workflow static-analysis-php.yml by detecting the the configuration file. Additionally there is now a detection for psalm.xml before executing the binary.

@Chrico Chrico requested a review from a team as a code owner January 6, 2025 13:37
@Chrico Chrico requested review from tfrommen and tyrann0us January 6, 2025 13:37
.github/workflows/static-analysis-php.yml Outdated Show resolved Hide resolved
.github/workflows/static-analysis-php.yml Outdated Show resolved Hide resolved
Co-authored-by: Thorsten Frommen <[email protected]>
Signed-off-by: Christian Leucht <[email protected]>
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% convinced not to enforce a file naming convention, but I won't block this either. In any case, the documentation needs to be updated.

.github/workflows/static-analysis-php.yml Outdated Show resolved Hide resolved
docs/php.md Outdated Show resolved Hide resolved
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Thorsten Frommen <[email protected]>
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Chrico Chrico merged commit 6a635a6 into main Jan 7, 2025
4 checks passed
@Chrico Chrico deleted the feature/phpstan branch January 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants