-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actionlint workflow #158
Conversation
Signed-off-by: Philipp Bammes <[email protected]>
PR checks are failing because of rhysd/actionlint#447. |
Signed-off-by: Philipp Bammes <[email protected]>
This reverts commit f78b02a.
This triggers a lot of errors in the `run:` steps, but this does not run reliably for all files, making the results unreliably. Also, some of reported errors are false positives, caused by how actionlint invokes shellcheck on the commands.
This was reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly that the workflow is bi-purposed: for our internal lint and for consuming as a reusable one? If so, should we add the documentation for consumers? Maybe there is not much to say, but still...
Well done. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Workflow files are not checked and may contain syntax errors.
What is the new behavior (if this is a feature change)?
All workflows files are checked with https://github.com/rhysd/actionlint.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Fixes #139
This is not an internal workflow but should be consumable by calling workflows.