Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QIT workflow #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add QIT workflow #137

wants to merge 1 commit into from

Conversation

AlexP11223
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce?

feature (new workflow)

The workflow for running the Woo Quality Insights Toolkit tests.

@AlexP11223 AlexP11223 requested a review from Biont July 12, 2024 07:03
@Chrico Chrico removed the request for review from Biont July 12, 2024 07:15
@luislard
Copy link
Contributor

I checked this; I need to familiarize myself with the QIT suite, but LGTM in general.

My only concern here is the dependency on the artifact produced by another workflow. Even if, in the future, this depends on a regular git tag pull, the changes needed shouldn't be too much. It would be a breaking change, though.

@AlexP11223
Copy link
Contributor Author

The artifact is just a standard WP plugin zip, not some custom format, so it is not tied just to our workflow.

QIT only works with plugin packages (zip), so pulling from git would not be useful here unless it's a very simple plugin without any build process.

But either way adding other ways to retrieve the input would not be a breaking change I think. You would just need to add another parameter and check which one is set (or detect format of a single parameter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants