Remove unnecessary and expensive hasService check #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR removes the
ContainerConfigurator::hasService
check insideContainerConfigurator::addService
.This is unnecessary and potentially expensive (especially with large and/or multiple and/or composite containers).
Previously, there was an exception thrown in case someone wanted to register a module with an existing ID. In 74cf1a5, the exception has been removed (for the reasons mentioned in #17).
This means, previously, we needed to know if there already is a service with the given ID. Now, we don't care, and we can simply
unset
the potentially-existing service asunset($foo)
does not care whether$foo
exists.What is the current behavior? (You can also link to an open issue here)
Calling
ContainerConfigurator::addService
will internally callContainerConfigurator::hasService
.What is the new behavior (if this is a feature change)?
Calling
ContainerConfigurator::addService
will attempt to unset the entry in the factory lookup table without checking if it exists first.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: