Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): upgrade to storybook 7 #978

Closed

Conversation

TobiasHeimGalindo
Copy link
Collaborator

@TobiasHeimGalindo TobiasHeimGalindo commented Jun 14, 2023

Closes #955

Proposed Changes

upgrade storybook to latest (7.0.21) to fix the docPage copy bug (see here: storybookjs/storybook#18611 (comment))

Breaking Changes/ToDos:

  • Migrate .stories.mdx files to MDX2:
    Completed the automated upgrade of the 64 .stories.mdx files from MDX1 to MDX2 format as prompted by Storybook. Please refer to the MDX2 section of the 7.0 migration guide for details.

  • Upgrade to Storybook's 7 New Framework Format:
    Migrated the project to use Storybook's new framework: @storybook/web-components-webpack5. This involved:
    Removing the dependencies: @storybook/builder-webpack5 and @storybook/manager-webpack5.
    Adding the dependency: @storybook/web-components-webpack5.
    Updating the framework field in main.js to use @storybook/web-components-webpack5.
    Removing the core.builder field in main.js.
    More about this new framework format can be found here.

  • Eslint Recommendations:
    In case we face any issues, we can always run the npx storybook@latest automigrate script to get the recommended ESLint configurations provided by Storybook.

@TobiasHeimGalindo TobiasHeimGalindo force-pushed the elements-#955-fix-storybook-cannot-be-copied branch from 56da667 to 1e4f6c6 Compare June 14, 2023 15:29
@TobiasHeimGalindo TobiasHeimGalindo changed the title fix(elements|storybook): upgrade storybook version fix(storybook): upgrade storybook version Jun 14, 2023
@TobiasHeimGalindo TobiasHeimGalindo force-pushed the elements-#955-fix-storybook-cannot-be-copied branch from 1e4f6c6 to 068c546 Compare June 15, 2023 10:15
@TobiasHeimGalindo
Copy link
Collaborator Author

Currently blocked by our current Node version, need to bump to v16

Storybook 7.0 requires Node 16 or above. If you are using an older version of Node, you will need to upgrade or keep using Storybook 6 in the meantime.

@TobiasHeimGalindo TobiasHeimGalindo changed the title fix(storybook): upgrade storybook version chore(storybook): upgrade to storybook 7 Jun 15, 2023
@TobiasHeimGalindo TobiasHeimGalindo force-pushed the elements-#955-fix-storybook-cannot-be-copied branch from 068c546 to 453c666 Compare June 29, 2023 08:17
@janivo janivo mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook content cannot be copied
1 participant