Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clarify and fix some strings #91

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

KobeW50
Copy link
Collaborator

@KobeW50 KobeW50 commented Oct 13, 2024

Changes:

  • Changed to consistent wording in the spoof app version menu.
  • Fixed typo in revanced_hide_seekbar_chapter_label_summary_off
  • Minor readability improvements in various places
  • Removed capitalization from all instances of "Handle" and "Username" (including in patch name and PreferenceScreen)

Regarding the last one, it is obvious that you capitalized them deliberately. However, in the YouTube > Settings RVX > General > Account menu and in YouTube > Settings RVX > Shorts > Shorts player, the word "handle" is not treated as a proper noun. This is the primary reason why I removed the capitalization.

@KobeW50 KobeW50 requested a review from inotia00 October 13, 2024 19:16
@ghost
Copy link

ghost commented Oct 13, 2024

The word username should stay as Username, with capital U.

Return YouTube Username, just like Return YouTube Dislike. The word Dislike has capital D, and not lowercase.

@KobeW50
Copy link
Collaborator Author

KobeW50 commented Oct 13, 2024

"Return YouTube Dislike" is a proper noun since it is the name of a project. But when referring to likes and dislikes in general, the words aren't capitalized.

@ghost
Copy link

ghost commented Oct 13, 2024

"Return YouTube Dislike" is a proper noun since it is the name of a project. But when referring to likes and dislikes in general, the words aren't capitalized.

And Return YouTube Username should stay untouched, to make it unified with other patches such as Return YouTube Dislike. Making it username instead of Username makes zero sense.

@KobeW50
Copy link
Collaborator Author

KobeW50 commented Oct 13, 2024

"Return YouTube Dislike" is a proper noun since it is the name of a project. But when referring to likes and dislikes in general, the words aren't capitalized.

And Return YouTube Username should stay untouched, to make it unified with other patches such as Return YouTube Dislike. Making it username instead of Username makes zero sense.

Return YouTube Dislike is the name of a project and API that the patch uses, which is why it is capitalized. Although the Return YouTube Username patch has a similar style function to RYD, it is not a formal name.

@ghost
Copy link

ghost commented Oct 13, 2024

"Return YouTube Dislike" is a proper noun since it is the name of a project. But when referring to likes and dislikes in general, the words aren't capitalized.

And Return YouTube Username should stay untouched, to make it unified with other patches such as Return YouTube Dislike. Making it username instead of Username makes zero sense.

Return YouTube Dislike is the name of a project and API that the patch uses, which is why it is capitalized. Although the Return YouTube Username patch has a similar style function to RYD, it is not a formal name.

Why change something just for the sake of changing? I just dont understand it. But you do you, I lost interest already. Go ahead, change everything what @inotia00 has done in the past, put your name on the board, make yourself known, leave your mark on the planet earth.

@Francesco146
Copy link

he is known for fixing strings to make the English language app consistent, he is not the typical guy who modifies the linux kernel readme and calls itself a linux mantainer. what he says makes sense, even if he doesn't know the code implementation behind the scenes

@inotia00
Copy link
Owner

The Return YouTube Username patch is inspired by Return YouTube Comment Username (Chrome Extensions)

Although the implementation is slightly different, the functionality is almost the same

At least in the patch name or the title of the settings, it seems appropriate to capitalize Username

It is okay to lowercase it in the description of the patch or the summary of the settings

@inotia00
Copy link
Owner

Thanks

@inotia00 inotia00 merged commit 373e6e6 into inotia00:dev Oct 14, 2024
@KobeW50 KobeW50 deleted the stringsv2 branch October 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants