-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clarify and fix some strings #91
Conversation
The word username should stay as Username, with capital U. Return YouTube Username, just like Return YouTube Dislike. The word Dislike has capital D, and not lowercase. |
"Return YouTube Dislike" is a proper noun since it is the name of a project. But when referring to likes and dislikes in general, the words aren't capitalized. |
And Return YouTube Username should stay untouched, to make it unified with other patches such as Return YouTube Dislike. Making it username instead of Username makes zero sense. |
Return YouTube Dislike is the name of a project and API that the patch uses, which is why it is capitalized. Although the |
Why change something just for the sake of changing? I just dont understand it. But you do you, I lost interest already. Go ahead, change everything what @inotia00 has done in the past, put your name on the board, make yourself known, leave your mark on the planet earth. |
he is known for fixing strings to make the English language app consistent, he is not the typical guy who modifies the linux kernel readme and calls itself a linux mantainer. what he says makes sense, even if he doesn't know the code implementation behind the scenes |
The Although the implementation is slightly different, the functionality is almost the same At least in the patch name or the title of the settings, it seems appropriate to capitalize It is okay to lowercase it in the description of the patch or the summary of the settings |
.../kotlin/app/revanced/patches/music/utils/returnyoutubeusername/ReturnYouTubeUsernamePatch.kt
Outdated
Show resolved
Hide resolved
Thanks |
Changes:
revanced_hide_seekbar_chapter_label_summary_off
Regarding the last one, it is obvious that you capitalized them deliberately. However, in the
YouTube > Settings RVX > General > Account menu
and inYouTube > Settings RVX > Shorts > Shorts player
, the word "handle" is not treated as a proper noun. This is the primary reason why I removed the capitalization.