Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Disable Music playback speed): Fix side effect left #108

Closed
wants to merge 1 commit into from

Conversation

YT-Advanced
Copy link

@YT-Advanced YT-Advanced commented Dec 16, 2024

In WEB and MWEB client, player response contains microformat JSONObject which provide us information about video category, such as Music, Entertainment, Education, etc. So we can use this useful field to check if a video is music or not.

Other changes:

  • Do not override playback speed on livestream by default (Remove settings)
  • Update client info

@inotia00
Copy link
Owner

inotia00 commented Dec 16, 2024

As far as I know, when using WEB or MWEB clients, the server sometimes returns a response Sign in to confirm you’re not a bot and asks for a poToken: LuanRT/YouTube.js#674

I will review the PR after it has been sufficiently tested

@YT-Advanced
Copy link
Author

YT-Advanced commented Dec 16, 2024

Ah got it. I think I should close this PRs. However, I will keep the branch in case u want to reopen it back xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants