Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): App crashes when Overlay buttons patch is excluded #2521

Closed
7 tasks done
NMBlanco opened this issue Dec 8, 2024 · 7 comments
Closed
7 tasks done

bug(YouTube): App crashes when Overlay buttons patch is excluded #2521

NMBlanco opened this issue Dec 8, 2024 · 7 comments
Labels
Bug report Something isn't working

Comments

@NMBlanco
Copy link

NMBlanco commented Dec 8, 2024

Type

Error at runtime

Tools used

RVX Manager

Application

19.16.39

Bug description

When the patching is finished (without any errors) and I click mount, then open YouTube, it immediately crashes.
Using latest 5.0.1 patches.

Error logs

No response

Solution

include Overlay buttons patch

Additional context

No response

Device Environment

Android 14

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@NMBlanco NMBlanco added the Bug report Something isn't working label Dec 8, 2024
@inotia00
Copy link
Owner

inotia00 commented Dec 8, 2024

Please attach crash log

@inotia00
Copy link
Owner

inotia00 commented Dec 8, 2024

Just a while ago I also patched and mounted YouTube 19.16.39 with RVX Manager

The issue is not reproduced on my side

Also the crash log points to the M method of the ccw class, but no patch was applied to this method

Can you provide a list of patches that are included or excluded?

@NMBlanco
Copy link
Author

NMBlanco commented Dec 8, 2024

Just a while ago I also patched and mounted YouTube 19.16.39 with RVX Manager

The issue is not reproduced on my side

Also the crash log points to the M method of the ccw class, but no patch was applied to this method

Can you provide a list of patches that are included or excluded?

Hm weird...
Here are the patches I selected:

- Device Info
RVX Manager: 1.23.4
Model: motorola edge 30 ultra
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: Yes

- Patch Info
App: com.google.android.youtube v19.16.39 (Suggested: 19.16.39)
Patches version: v5.0.1
Patches added: Force hide player buttons background, Hide Shorts dimming, Return YouTube Username
Patches removed: Hook YouTube Music actions, Custom Shorts action buttons, Custom branding name for YouTube, Translations for YouTube, Enable debug logging, Overlay buttons, Swipe controls, GmsCore support
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: false
Show universal patches: false
Remove unused library: false
Use pre-release: true
Patches source: inotia00/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 51 patches
Compiling modified resources
Aligning APK
Signing APK
Patched APK
Mounting patched app
Installed

And the RVX Manager log attached.
revanced-manager_logcat_20241208154113656640.log

@inotia00
Copy link
Owner

inotia00 commented Dec 8, 2024

I re-patched the same patch list you provided and was able to reproduce the issue on my side

@inotia00
Copy link
Owner

inotia00 commented Dec 8, 2024

It looks like the Overlay buttons patch is causing the issue

Would you please include this patch and try again?

@inotia00 inotia00 added the Waiting on author OP's answer is needed label Dec 8, 2024
@inotia00 inotia00 changed the title bug: YouTube immediately crashes after patching bug(YouTube): App crashes when Overlay buttons patch is excluded Dec 8, 2024
@NMBlanco
Copy link
Author

NMBlanco commented Dec 8, 2024

It looks like the Overlay buttons patch is causing the issue

Would you please include this patch and try again?

Yes with this patch enabled I got it to work. No crash anymore. Thanks!

@inotia00 inotia00 removed the Waiting on author OP's answer is needed label Dec 8, 2024
@inotia00 inotia00 pinned this issue Dec 8, 2024
@inotia00
Copy link
Owner

inotia00 commented Dec 8, 2024

fixed in revanced-patches-5.0.2

@inotia00 inotia00 closed this as completed Dec 8, 2024
@inotia00 inotia00 unpinned this issue Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants