bug(YouTube/Hide Visit store button): The 'Visit store' button on channel profile isn't hidden

[ILoveOpenSourceApplications]

Type

Error at runtime

Tools used

RVX Manager

Application

YouTube v19.19.39

Bug description

Hide 'Visit store' button isn't working.

Error logs

No response

Solution

Adding the litho component: ^channel_profile.eml$header_store_button in custom filter seems to work.

04-21 18:08:29.982 11186 11186 D revanced: LithoFilterPatch: Searching ID: null Path: channel_profile.eml|fe7264abae464c88|channel_profile_phone.eml|4a5e3ed8b99b52ed|ContainerType|channel_action_buttons_phone.eml|93f701b73481db51|ContainerType|button.eml|e4d01425197b9e68|ContainerType| BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖUCV6mNrW8CrmWtcxWfQXy11gΓ¥Ö8gYEEgIqAA%3D%3D"Γ¥Ö/@DarkViperAUΓ¥Ö
04-21 18:08:29.982 11186 11186 D revanced: LithoFilterPatch: Searching ID: null Path: channel_profile.eml|fe7264abae464c88|channel_profile_phone.eml|4a5e3ed8b99b52ed|ContainerType|channel_action_buttons_phone.eml|93f701b73481db51|ContainerType|button.eml|e4d01425197b9e68|ContainerType|TextType| BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖUCV6mNrW8CrmWtcxWfQXy11gΓ¥Ö8gYEEgIqAA%3D%3D"Γ¥Ö/@DarkViperAUΓ¥Ö

Additional context

No response

Device Environment

No response

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[ILoveOpenSourceApplications]

Commits:
ReVanced/revanced-patches@04ea9c3
ReVanced/revanced-integrations@801ec76

[ILoveOpenSourceApplications]

I hadn't updated to 4.8.6 since the changelogs didn't have many changes that interested me and this wasn't mentioned either. Looks like it was fixed. Closing this then.

[ILoveOpenSourceApplications]

On an unrelated note @inotia00, the method which is used to hide the individual tabs on the channel profile, is it a complex method or is it something simple?

[KobeW50]

I it helps, I think this is the relavent code.

Patch: https://github.com/inotia00/revanced-patches/blob/revanced-extended/src%2Fmain%2Fkotlin%2Fapp%2Frevanced%2Fpatches%2Fyoutube%2Ffeed%2Fcomponents%2FFeedComponentsPatch.kt#L244-L284

Integrations: https://github.com/inotia00/revanced-integrations/blob/revanced-extended/app%2Fsrc%2Fmain%2Fjava%2Fapp%2Frevanced%2Fintegrations%2Fyoutube%2Fpatches%2Ffeed%2FFeedPatch.java#L36-L61

[ILoveOpenSourceApplications]

Also @KobeW50, shouldn't it be 'Visit store'?

[ILoveOpenSourceApplications]

The patch was renamed, but the button isn't hidden for me.

[KobeW50]

Also @KobeW50, shouldn't it be 'Visit store'?

I'm not sure. Based off of this comment and the third commit in this PR I would assume that it shouldn't have single quotes. This is why I made this commit to revert many of the single-quotes that added earlier in the PR.

I'm not sure if the stuff that has single-quotes in Revanced is meant to have them in RVX (eg: Hide 'For you' shelf)

[ILoveOpenSourceApplications]

Single word components are so far the ones which use a first letter capitalize method. If it's a two word component, I think the quotation is used to indicate that both the word is part of the component.

[ILoveOpenSourceApplications]

Examples: 'For you', 'Notify me', and now 'Visit store'.

[KobeW50]

Single word components are so far the ones which use a first letter capitalize method. If it's a two word component, I think the quotation is used to indicate that both the word is part of the component.

Examples: 'For you', 'Notify me', and now 'Visit store'.

It makes sense, but I understand why it isn't desirable to have quotes. It makes the settings look cluttered, and the sentences aren't truly ambiguous without them.

For example, in the title Hide Playback speed menu, it is obvious that "speed" must be connected to "Playback", and that "menu" is separate and not part of the proper noun.

Regardless of the convention, it should always be consistent. So either every multi-word proper noun has quotes, or none should have quotes.

[ILoveOpenSourceApplications]

Regardless of the convention, it should always be consistent. So either every multi-word proper noun has quotes, or none should have quotes.

Yes. This is a decision that needs to be made by @inotia00.

[inotia00]

reflected in revanced-patches-4.9.1-dev.1

[ILoveOpenSourceApplications]

It's still not hidden.

[inotia00]

It works for me

[ILoveOpenSourceApplications]

Video

Screen_Recording_20240611_101933_YouTube.mp4

[ILoveOpenSourceApplications]

I'll do a litho check again. Even when adding ^channel_profile.eml$header_store_button to custom filters, the button isn't hidden for me.

[inotia00]

If so, the path would have changed

Attach an Extended debug logging, not the debug logging of the revanced

[ILoveOpenSourceApplications]

The path did change. It's now ^page_header.eml$header_store_button and leaves behind a blank space where the button was unlike the previous one.

06-11 11:16:42.181 16748 16748 D Extended: LithoFilterPatch: Path: page_header.eml|29bf20f8b14236d4|ContainerType|ContainerType|ContainerType|flexible_actions.eml|daf1064fca739913|ContainerType|ContainerType|ContainerType|button.eml|ebc698722222cbfe|ContainerType|
06-11 11:16:42.181 16748 16748 D Extended: LithoFilterPatch: BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖVisit storeΓ¥ÖUCeeFfhMcJa1kjtfZAGskOCAΓ¥ÖEgVzdG9yZfIGBBICKgA%3D"Γ¥Ö/@techlinkedΓ¥Ö

[inotia00]

Thanks, I'm sure that this is an A/B tests

[ILoveOpenSourceApplications]

Should be. I will try and see if it returns to the old one and if so, all is well. But if not, their will be a blank space of nothing when the button is hidden, thanks YouTube.

[ILoveOpenSourceApplications]

It makes sense, but I understand why it isn't desirable to have quotes. It makes the settings look cluttered, and the sentences aren't truly ambiguous without them.

For example, in the title Hide Playback speed menu, it is obvious that "speed" must be connected to "Playback", and that "menu" is separate and not part of the proper noun.

Regardless of the convention, it should always be consistent. So either every multi-word proper noun has quotes, or none should have quotes.

Also, @inotia00 any comments on this?

[inotia00]

It's off-topic
If you need a discussion to improve the patch description or string, a new issue should be opened

[ILoveOpenSourceApplications]

Okay. Opened a new issue.

[inotia00]

reflected in revanced-patches-4.9.1

FYI: Hidden, but still left empty space