Upgrade/mdast util math #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2023
Closed
|
Hey there, saw that you merged this PR and that you opened a new related PR to support mdast v4: #174. I'm curious why the v4 support PR was closed. Also, what is the release timeline for these changes? |
|
I've noticed your fix was not enough because there are many breaking changes in mdast v5(@types/mdast : 4). |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm working on a project that uses
remark-gfmand otherremarklibraries as well as this library 😄. Recently, when upgradingremark-gfmto version"^4.0.0"there was an issue which was traced to different versions of the transitive dependency,mdast-util-to-markdown, betweenremark-gfm@^4.0.0and[email protected]. In this PR, I am bumping themdast-util-mathversion to v3, which uses v2 ofmdast-util-to-markdown.This is my first time contributing to this library. I ran tests locally and manually tested using the storybook playground- didn't see any breaking changes with this upgrade. Let me know if there is more I should do!