Merge pull request #147 from inokawa/issue142

Fixed bug that inlineCode could be undefined in slate to remark

src/__snapshots__/index.spec.ts.snap

@@ -10469,6 +10469,33 @@ exports[`issues issue145 2`] = `
 "
 `;
 
+exports[`issues issue145-2 1`] = `
+{
+  "children": [
+    {
+      "children": [
+        {
+          "children": [
+            {
+              "type": "inlineCode",
+              "value": "code",
+            },
+          ],
+          "type": "emphasis",
+        },
+      ],
+      "type": "paragraph",
+    },
+  ],
+  "type": "root",
+}
+`;
+
+exports[`issues issue145-2 2`] = `
+"_\`code\`_
+"
+`;
+
 exports[`options override builders 1`] = `
 [
   {

src/index.spec.ts

@@ -278,4 +278,23 @@ describe("issues", () => {
     const text = processor.stringify(ast);
     expect(text).toMatchSnapshot();
   });
+
+  it("issue145-2", () => {
+    const processor = unified()
+      .use(markdown)
+      .use(slateToRemark)
+      .use(stringify, { emphasis: "_" });
+    const ast = processor.runSync({
+      type: "root",
+      children: [
+        {
+          type: "paragraph",
+          children: [{ emphasis: true, inlineCode: true, text: "code" }],
+        },
+      ],
+    } as any);
+    expect(ast).toMatchSnapshot();
+    const text = processor.stringify(ast);
+    expect(text).toMatchSnapshot();
+  });
 });

src/transformers/slate-to-mdast/index.ts

@@ -81,7 +81,16 @@ const convertTexts = (
     const prev = slateTexts[j - 1];
     const next = slateTexts[j + 1];
     ends = [];
-    (["inlineCode", "emphasis", "strong", "delete"] as const).forEach((k) => {
+    (
+      [
+        "emphasis",
+        "strong",
+        "delete",
+        // inlineCode should be last because of the spec in mdast
+        // https://github.com/inokawa/remark-slate-transformer/issues/145
+        "inlineCode",
+      ] as const
+    ).forEach((k) => {
       if (cur[k]) {
         if (!prev || !prev[k]) {
           starts.push(k);