-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) add AdvancedMarker component #263
Merged
HusamElbashir
merged 6 commits into
inocan-group:develop
from
VictorBalbo:feature/add-advanced-marker-component
Aug 4, 2024
Merged
(Feature) add AdvancedMarker component #263
HusamElbashir
merged 6 commits into
inocan-group:develop
from
VictorBalbo:feature/add-advanced-marker-component
Aug 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorBalbo
changed the title
Feature/add advanced marker component
(Feature) add AdvancedMarker component
Jul 12, 2024
VictorBalbo
force-pushed
the
feature/add-advanced-marker-component
branch
from
July 15, 2024 17:34
c7e69e2
to
e76a80d
Compare
MichaelVini
reviewed
Jul 26, 2024
@MichaelVini Will this be merged anytime soon? |
I don't have permission to merge the PR I just added a comment with a question. However, I would like this to be merged as I also need it 😄 |
MichaelVini
reviewed
Jul 31, 2024
MichaelVini
reviewed
Jul 31, 2024
MichaelVini
reviewed
Jul 31, 2024
MichaelVini
reviewed
Jul 31, 2024
HusamElbashir
force-pushed
the
feature/add-advanced-marker-component
branch
from
August 4, 2024 22:51
aee5cbd
to
020e1f9
Compare
HusamElbashir
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @VictorBalbo !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
AdvancedMarker
component as it is the replacement forMarker
component.Marker component still exists, the new component was added just as a new option