Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak for 2024e #113

Merged
merged 2 commits into from
Jan 6, 2025
Merged

tweak for 2024e #113

merged 2 commits into from
Jan 6, 2025

Conversation

celeron533
Copy link
Contributor

duplicated "enhanced-mr-image:300a012c"
in file tmp/modules_attributes_updated_references.json version 2024e

line 290388

    {
        "moduleId":"enhanced-mr-image",
        "path":"enhanced-mr-image:300a012c",
        "tag":"(300A,012C)",
        "type":"3",
        "linkToStandard":"http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.8.13.html#table_C.8-79",
        "description":"<p>\nIsocenter coordinates (x,y,z), in mm. Specifies the location of the machine isocenter in the Patient-Based Coordinate System associated with the Frame of Reference. It allows transformation from the Equipment-Based Coordinate System to the Patient-Based Coordinate System.</p>",
        "conditional":null,
        "externalReferences":[]
    },

line 293574

    {
        "moduleId":"enhanced-mr-image",
        "path":"enhanced-mr-image:300a012c",
        "tag":"(300A,012C)",
        "type":"3",
        "linkToStandard":"http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.8.13.html#table_C.8-79",
        "description":"<p>\nIsocenter coordinates (x,y,z), in mm.\n                                            Specifies the location of the machine isocenter in the Patient-Based Coordinate System associated with the Frame of Reference.\n                                            It allows transformation from the Equipment-Based Coordinate System to the Patient-Based Coordinate System.</p>",
        "conditional":null,
        "externalReferences":[]
    },

Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to update the exceptions table in the README as appropriate.

@johndgiese
Copy link
Contributor

If you don't think updates are needed, let me know and I can merge this.

@celeron533
Copy link
Contributor Author

Thanks for the remainder. I'll update the readme tomorrow or next week. :)

@celeron533
Copy link
Contributor Author

Or you can merge this PR first. I'll update the document in a new PR later.

@johndgiese
Copy link
Contributor

@celeron533 unless you're in a hurry to have the new updates live, I'd prefer to have the related changes made all together in a single PR.

@celeron533
Copy link
Contributor Author

The readme.md is updated.

@johndgiese
Copy link
Contributor

Thanks @celeron533 this is great! I'll merge it!

@johndgiese johndgiese merged commit dcf7254 into innolitics:master Jan 6, 2025
@celeron533 celeron533 deleted the 2024e branch January 7, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants